Update screenshot UI Tests with new designs - #13082
Merged
JavonDavis merged 10 commits intoNov 20, 2020
Merged
Conversation
…/WordPress-Android into update/screenshot-ui-tests-with-new-designs
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
Contributor
|
Heads up I branched off of this branch and tested your changes with the mock changes on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the UI Tests that will be used for the screenshots project.
Challenges
git pull origin fix/screenshot-ui-teststo pull in the work from Fix/screenshot ui tests #13031.fix/screenshot-ui-testsbranch, I still get one failed test with a wiremock error which I am not sure how to get around (see Fix/screenshot ui tests #13031 (review) for details), but I think updating mocked data will resolve it.Updated mock data is a blocker at this point and I need help with that part.
To test:
fix/screenshot-ui-testsbranch.WPScreensotTestas the run configuration.PR submission checklist:
RELEASE-NOTES.txtif necessary.