Skip to content

Update mocks for screenshots - #13123

Merged
JavonDavis merged 22 commits into
developfrom
update/mocks-for-screenshots
Nov 20, 2020
Merged

Update mocks for screenshots#13123
JavonDavis merged 22 commits into
developfrom
update/mocks-for-screenshots

Conversation

@JavonDavis

Copy link
Copy Markdown
Contributor

Updates the mocks for the app store screenshots

To test: Run screenshot tests

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Oct 13, 2020

Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Oct 13, 2020

Copy link
Copy Markdown
Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@JavonDavis JavonDavis changed the title Update/mocks for screenshots Update mocks for screenshots Oct 13, 2020
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Oct 13, 2020

Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading the APK here.

@designsimply designsimply left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to get tests to work after updating to ddf3166! 🎉

The Discover screenshot looks amaaaazing. Yay! 😍

Nitpick: there's a gray overlay on the stats screen that isn't there when I browse with the app directly. Note that this may not matter if the overlay isn't present when generating screenshots at the fastlane level (I observed this in the test directly).

Screenshot_1602693727

Nitpick: images in the media screenshot don't match the ones in the figma. This also might not matter but we could double check with Megs on the design if you want!

Screenshot_1602700812

@JavonDavis
JavonDavis merged commit 772a15f into develop Nov 20, 2020
@JavonDavis
JavonDavis deleted the update/mocks-for-screenshots branch April 17, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants