Fix migration flow error when changing device settings mid-flow

[ovitrif]

Fixes #17646

This PR ensures the migration flow can be continued if device settings are changed mid-flow.

Note: Currently I'm not sure which should be the target branch for this PR, either trunk or release/21.3.
Since I started on top of release/21.3 it's set for the moment to target that branch.
There are merge conflicts that need to be fixed before this PR can be merged in 21.3
Updated to target trunk as discussed

To test:

0. Prerequisite WordPress app of the same flavor should be installed and logged in.
1. Uninstall and reinstall Jetpack app but don’t open it.
2. Tap “try the new Jetpack app” in the WordPress app
3. See the “Welcome” screen. (alternately: Tap “continue” to go to the “Notifications come from Jetpack screen” or the flow completion screen)
4. Open Android Settings and change language, or switch light/dark mode.
5. Swipe back over to the Jetpack app.
6. Expect To be able to continue (no error screen), from the last shown migration screen
7. Continue the flow expecting it to work as intended without errors.

🧪 Test "Delete WordPress App Screen" for no regression

After completing the flow in the Jetpack app:

1. Tap the "Please delete the WordPress app" card on My Site
2. Expect to see the screen informing you to delete the WordPress app
3. Open Android Settings and change language, or switch light/dark mode.
4. Go back to the Jetpack app
5. Expect to see the screen to delete the WordPress app updated based on the changed settings.
6. Tap the Got it button
7. Expect to land on the My Site screen

Preview

change_settings_midflow.mp4

Regression Notes

1. Potential unintended areas of impact

   • Delete WP app screen (accessible from from My Site after completing the migration flow).
   • Migration flow UI in Jetpack app.

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   Manual testing.

3. What automated tests I added (or what prevented me from doing so)
   Added test to check migration is not retried.

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[antonis]

Note: Currently I'm not sure which should be the target branch for this PR, either trunk or release/21.3.
Since I started on top of release/21.3 it's set for the moment to target that branch.
There are merge conflicts that need to be fixed before this PR can be merged in 21.3

Thank you for jumping into this so quickly @ovitrif and preparing a PR 🙇
Let's target trunk for this both to avoid the conflict and because it feels like an edge case to me. Wdyt?

[ovitrif]

Thank you for jumping into this so quickly @ovitrif and preparing a PR 🙇 Let's target trunk for this both to avoid the conflict and because it feels like an edge case to me. Wdyt?

Sounds good to me @antonis, thank you for your suggestion 🙇

P.S. I'll see what I can do to update this so that it targets trunk 👍

P.P.S. I do agree it's more of an edge case 👍

[wpmobilebot]

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17659-ae8a38f.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	WordPress
	Build Flavor	Jalapeno
	Build Type	Debug
	Commit	ae8a38f

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

[wpmobilebot]

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17659-ae8a38f.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	Jetpack
	Build Flavor	Jalapeno
	Build Type	Debug
	Commit	ae8a38f

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

[antonis]

Great work @ovitrif 👍
I've tested the PR on a Google Pixel 5 (Android 13) and everything worked as expected for me. The code changes also make sense 🎉