Skip to content

Jetpack Focus: Intercept reader links in p4 and redirect to main view - #17978

Merged
AjeshRPai merged 1 commit into
trunkfrom
issue/jetpack-focus-web-links-phase4
Feb 19, 2023
Merged

Jetpack Focus: Intercept reader links in p4 and redirect to main view#17978
AjeshRPai merged 1 commit into
trunkfrom
issue/jetpack-focus-web-links-phase4

Conversation

@zwarm

@zwarm zwarm commented Feb 17, 2023

Copy link
Copy Markdown
Contributor

This PR reverts the revert in #17851 to address the case where reader web links are not being redirected to the main view. Yes, this means that for these particular web links an overlay won't be shown, but for now that is okay (as the overlay was a last minute addition as a nice-to-have). We will eventually sort out the showing of the overlay for these instances, but the immediate need is to stop the user from being dropped into an feature of the app which has been removed.

To test:
To test:
Decompress and download the attached links_helper.html file to your device (github doesn't support html file attachments)
links_helper.html.zip

Pre reqs

  • Uninstall all previous versions of JP & WP
  • Install the WP APK from this PR and login
  • Enable the pre-alpha WP app to handle verified web links links. On a pixel device you will find this under Open By Default > Tap + Add Link > Check all three checkboxes and then click Add.

Non-Phase 4 Test

  • Tap on each link in the Custom Scheme: Wordpress PreAlpha links section
  • ✅ Verify that each link opens to the correct place in the WordPress app
  • Tap on each link in the Custom Scheme: WordPress intents with NO package specified section. Select to open with WP
  • ✅ Verify that each link opens to the correct place in the WordPress app
  • Tap on each link in the Web Links section
  • ✅ Verify that each link opens to the correct place in the WordPress app

Phase 4 Test

  • Navigate to Me -> App Settings -> Debug Settings
  • Enable jp_removal_four and restart the app
  • Tap on each link in the Custom Scheme: Wordpress PreAlpha links section
  • ✅ Verify that each link opens to the home view place in the WordPress app
  • Tap on each link in the Custom Scheme: WordPress intents with NO package specified section. Select to open with WP
  • ✅ Verify that each link opens to the home view in the WordPress app
  • Tap on each link in the Web Links section
  • ✅ Verify that each link opens to the home view in the WordPress app

Regression Notes

  1. Potential unintended areas of impact
    User are able to deep link into jetpack areas when phase 4 is current

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@zwarm zwarm added this to the 21.8 milestone Feb 17, 2023
@zwarm
zwarm requested a review from AjeshRPai February 17, 2023 20:14
@zwarm zwarm self-assigned this Feb 17, 2023
@peril-wordpress-mobile

Copy link
Copy Markdown
Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot

Copy link
Copy Markdown
Contributor
WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17978-aa9b127.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commitaa9b127
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot

Copy link
Copy Markdown
Contributor
Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17978-aa9b127.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commitaa9b127
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@AjeshRPai AjeshRPai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zwarm ,
I have tested all the scenarios in the description. Everything works as expected 👍🏼 . 🟢
Thanks for fixing this 👏🏼

@AjeshRPai
AjeshRPai merged commit c3d9713 into trunk Feb 19, 2023
@AjeshRPai
AjeshRPai deleted the issue/jetpack-focus-web-links-phase4 branch February 19, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants