Skip to content

Follow up: Replaces bundle usage in the editor with a local database#19761

Merged
antonis merged 2 commits into
trunkfrom
fix/19157-TransactionTooLargeException2
Dec 11, 2023
Merged

Follow up: Replaces bundle usage in the editor with a local database#19761
antonis merged 2 commits into
trunkfrom
fix/19157-TransactionTooLargeException2

Conversation

@antonis

@antonis antonis commented Dec 8, 2023

Copy link
Copy Markdown
Contributor

Description

This is a follow up PR of #19747 handling optional review feedback


To Test:

Check instructions in #19747


Regression Notes

  1. Potential unintended areas of impact

N/A

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

N/A

  1. What automated tests I added (or what prevented me from doing so)

N/A


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@antonis antonis added Gutenberg Editing and display of Gutenberg blocks. Tech Debt labels Dec 8, 2023
@antonis
antonis requested a review from justtwago December 8, 2023 18:31
@wpmobilebot

Copy link
Copy Markdown
Contributor
1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@antonis antonis added this to the 23.9 milestone Dec 8, 2023
@peril-wordpress-mobile

Copy link
Copy Markdown
Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@antonis antonis changed the title Fix/19157 transaction too large exception2 Follow up: Replaces bundle usage in the editor with a local database Dec 8, 2023
@wpmobilebot

Copy link
Copy Markdown
Contributor
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19761-9a47820
Commit9a47820
Direct Downloadjetpack-prototype-build-pr19761-9a47820.apk
Note: Google Login is not supported on these builds.

@wpmobilebot

Copy link
Copy Markdown
Contributor
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19761-9a47820
Commit9a47820
Direct Downloadwordpress-prototype-build-pr19761-9a47820.apk
Note: Google Login is not supported on these builds.

@justtwago justtwago left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the follow-up changes! LGTM 🚀

@antonis

antonis commented Dec 11, 2023

Copy link
Copy Markdown
Contributor Author

Thank you for the prompt review Artyom 🙇

@antonis
antonis merged commit df351b5 into trunk Dec 11, 2023
@antonis
antonis deleted the fix/19157-TransactionTooLargeException2 branch December 11, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks. Tech Debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants