feat: assign "debug" release, when app is not in release variant - #20545
Merged
Conversation
To declutter Sentry dashboard
wzieba
marked this pull request as ready for review
March 27, 2024 19:08
|
Contributor
|
Found 1 violations: The PR caused some dependency changes (expand to see details)
+--- project :libs:analytics
-| \--- com.automattic:Automattic-Tracks-Android:3.6.0
+| \--- com.automattic:Automattic-Tracks-Android:4.0.2
+--- project :libs:editor
-| \--- com.automattic:Automattic-Tracks-Android:3.6.0 (*)
+| \--- com.automattic:Automattic-Tracks-Android:4.0.2 (*)
-\--- com.automattic:Automattic-Tracks-Android:{strictly 3.6.0} -> 3.6.0 (*)
+\--- com.automattic:Automattic-Tracks-Android:{strictly 4.0.2} -> 4.0.2 (*)
Please review and act accordingly
|
Contributor
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20545-293969a | |
| Commit | 293969a | |
| Direct Download | wordpress-prototype-build-pr20545-293969a.apk |
Contributor
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20545-293969a | |
| Commit | 293969a | |
| Direct Download | jetpack-prototype-build-pr20545-293969a.apk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #20545 +/- ##
=======================================
Coverage 40.24% 40.24%
=======================================
Files 1463 1463
Lines 67600 67602 +2
Branches 11201 11202 +1
=======================================
+ Hits 27205 27207 +2
Misses 37934 37934
Partials 2461 2461 ☔ View full report in Codecov by Sentry. |
crazytonyli
approved these changes
Mar 27, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Description
This PR bumps Tracks to
4.0.2. The major change here is that we delegate creating a release name to Tracks library (Sentry internally), instead of providing value from our build config.This will address a problem of matching a release with the same name from different projects in the same Sentry organization.
Additionally, in debug/PR builds, we'll assign a
debugrelease. This way, we'll clean up Sentry dashboard, as currently we have dozens of "pr-0000-00000" releases.To Test:
Screen from a test issue on release build type:
and on debug build type:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):