Skip to content

feat: assign "debug" release, when app is not in release variant - #20545

Merged
wzieba merged 2 commits into
trunkfrom
tracks_4_0_1
Mar 28, 2024
Merged

feat: assign "debug" release, when app is not in release variant#20545
wzieba merged 2 commits into
trunkfrom
tracks_4_0_1

Conversation

@wzieba

@wzieba wzieba commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

Description

This PR bumps Tracks to 4.0.2. The major change here is that we delegate creating a release name to Tracks library (Sentry internally), instead of providing value from our build config.

This will address a problem of matching a release with the same name from different projects in the same Sentry organization.

Additionally, in debug/PR builds, we'll assign a debug release. This way, we'll clean up Sentry dashboard, as currently we have dozens of "pr-0000-00000" releases.


To Test:

Screen from a test issue on release build type:

Screenshot 2024-03-27 at 19 47 23

and on debug build type:

image


Regression Notes

  1. Potential unintended areas of impact

    • Assigning incorrect release name to an issue
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Test Sentry issues, see above
  3. What automated tests I added (or what prevented me from doing so)

    • Unit tests

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wzieba wzieba added the Tooling label Mar 27, 2024
@wzieba wzieba added this to the 24.6 milestone Mar 27, 2024
@wzieba
wzieba requested a review from crazytonyli March 27, 2024 19:07
@wzieba
wzieba marked this pull request as ready for review March 27, 2024 19:08
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wpmobilebot

Copy link
Copy Markdown
Contributor

Found 1 violations:

The PR caused some dependency changes (expand to see details)

 +--- project :libs:analytics
-|    \--- com.automattic:Automattic-Tracks-Android:3.6.0
+|    \--- com.automattic:Automattic-Tracks-Android:4.0.2
 +--- project :libs:editor
-|    \--- com.automattic:Automattic-Tracks-Android:3.6.0 (*)
+|    \--- com.automattic:Automattic-Tracks-Android:4.0.2 (*)
-\--- com.automattic:Automattic-Tracks-Android:{strictly 3.6.0} -> 3.6.0 (*)
+\--- com.automattic:Automattic-Tracks-Android:{strictly 4.0.2} -> 4.0.2 (*)

Please review and act accordingly

@wpmobilebot

Copy link
Copy Markdown
Contributor
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20545-293969a
Commit293969a
Direct Downloadwordpress-prototype-build-pr20545-293969a.apk
Note: Google Login is not supported on these builds.

@wpmobilebot

Copy link
Copy Markdown
Contributor
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20545-293969a
Commit293969a
Direct Downloadjetpack-prototype-build-pr20545-293969a.apk
Note: Google Login is not supported on these builds.

@codecov

codecov Bot commented Mar 27, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.24%. Comparing base (569b0a4) to head (293969a).

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #20545   +/-   ##
=======================================
  Coverage   40.24%   40.24%           
=======================================
  Files        1463     1463           
  Lines       67600    67602    +2     
  Branches    11201    11202    +1     
=======================================
+ Hits        27205    27207    +2     
  Misses      37934    37934           
  Partials     2461     2461           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crazytonyli crazytonyli mentioned this pull request Mar 27, 2024
3 tasks
@wzieba
wzieba merged commit 693db93 into trunk Mar 28, 2024
@wzieba
wzieba deleted the tracks_4_0_1 branch March 28, 2024 07:46
@sentry

sentry Bot commented Apr 6, 2024

Copy link
Copy Markdown

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ApplicationNotResponding: Background ANR org.wordpress.android.util.crashlogging.WPCrash... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants