Skip to content

Remove Jetpack Lazy Images setting - #21575

Merged
nbradbury merged 6 commits into
trunkfrom
issue/21574-remove-jp-lazy-images
Jan 10, 2025
Merged

Remove Jetpack Lazy Images setting#21575
nbradbury merged 6 commits into
trunkfrom
issue/21574-remove-jp-lazy-images

Conversation

@nbradbury

Copy link
Copy Markdown
Contributor

Fixes #21574

As noted on this iOS PR, the Jetpack "Lazy images" setting has been removed from the backend, but we continued to show it in the apps.

This PR addresses this by removing this setting, and also adjusts the Site Accelerator screen to make more visual sense. Note that there's more to do here - our Jetpack settings are a bit of a mess - but this is a step in the right direction.

To test:

  • Switch to a Jetpack site
  • Go to Site settings
  • Scroll down to the Performance section
  • Note that there's no "Lazy load images" setting under this section
  • Tap on Site Accelerator
  • Note that the screen makes more visual sense(before and after below)

BEFORE

before

AFTER

after

@dangermattic

dangermattic commented Jan 10, 2025

Copy link
Copy Markdown
Collaborator
2 Warnings
⚠️ strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot

wpmobilebot commented Jan 10, 2025

Copy link
Copy Markdown
Contributor
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21575-96eb856
Commit96eb856
Direct Downloadwordpress-prototype-build-pr21575-96eb856.apk
Note: Google Login is not supported on these builds.

@wpmobilebot

wpmobilebot commented Jan 10, 2025

Copy link
Copy Markdown
Contributor
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21575-96eb856
Commit96eb856
Direct Downloadjetpack-prototype-build-pr21575-96eb856.apk
Note: Google Login is not supported on these builds.

@codecov

codecov Bot commented Jan 10, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.48%. Comparing base (1fc1a55) to head (96eb856).
Report is 7 commits behind head on trunk.

Files with missing lines Patch % Lines
.../wordpress/android/ui/prefs/WPComSiteSettings.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21575   +/-   ##
=======================================
  Coverage   39.48%   39.48%           
=======================================
  Files        2117     2117           
  Lines       99464    99464           
  Branches    15296    15296           
=======================================
  Hits        39269    39269           
  Misses      56714    56714           
  Partials     3481     3481           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nbradbury
nbradbury marked this pull request as ready for review January 10, 2025 16:55
@nbradbury
nbradbury requested a review from dcalhoun January 10, 2025 16:55

@dcalhoun dcalhoun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always feels great to delete code. 🔥

Comment thread WordPress/src/main/res/xml/site_settings.xml
@sonarqubecloud

Copy link
Copy Markdown

@nbradbury
nbradbury merged commit e159adc into trunk Jan 10, 2025
@nbradbury
nbradbury deleted the issue/21574-remove-jp-lazy-images branch January 10, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove "Lazy Images" Jetpack option

4 participants