CMM-1037 Home page picker fragment empty view

[nbradbury]

As part of CMM-1037, this PR updates the empty view for the HomePagePickerFragment.

To test

• Enable airplane mode
• On My Site, tap the dropdown arrow at the top right to switch sites
• When the site picker appears, tap the FAB
• Tap "Add a site"
• Tap "Create WordPress.com site"
• Skip choosing a theme
• In the subsequent screen, verify the empty view appears correctly

Before and after shots

[nbradbury]

@claude

[dangermattic]

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

[claude]

Claude finished @nbradbury's task in 1m 24s —— View job

---

Code Review Complete ✓

I've reviewed the changes in this PR. Overall, this is a clean and focused UI improvement that successfully simplifies the empty view presentation. Here's my comprehensive feedback:

---

Summary of Changes

This PR makes three related improvements to empty view displays:

1. Home Page Picker Fragment - Removes image and landscape hiding behavior, changes height to match_parent for better centering
2. History List Fragment - Removes image for consistency
3. String Resources - Makes history empty state messages more concise and natural

---

Code Quality ✅

Strengths:

• Clean, focused changes with a clear purpose
• Consistent pattern applied across related screens (home page picker and history list)
• The removal of aevImageHiddenInLandscape attribute simplifies the layout logic
• Height change from wrap_content to match_parent ensures proper vertical centering

Visual Improvement:
The before/after screenshots show a significant improvement. The "After" version is cleaner, more focused, and better centered. Removing the illustration reduces visual clutter and puts more emphasis on the actionable message.

---

String Resource Improvements ✅

The string rewording is excellent:

• Before: "When you make changes to your page you'll be able to see the history here"
• After: "You'll see this page's history when you make changes to it"

This is more concise, more active, and reads more naturally. Good work!

---

Security ✅

No security concerns. These are UI-only changes to layout files and string resources.

---

Performance ✅

Positive impact:

• Removing the image drawable (img_illustration_empty_results_216dp) means one less asset to load and render
• Simpler layout hierarchy without image and conditional landscape logic
• Should result in slightly faster rendering of empty states

---

Testing Considerations ⚠️

What's covered:

• The PR description provides clear manual testing instructions
• Visual regression is shown in the before/after screenshots

Potential gaps:

1. Rotation testing: Since you removed aevImageHiddenInLandscape, it would be good to verify the empty view looks correct in landscape mode (though this is likely fine since there's no image anymore)
2. Different screen sizes: Consider testing on various screen densities and sizes to ensure the centered text looks good everywhere
3. Accessibility: Ensure the empty view is still accessible without the image (likely not an issue, but worth verifying with TalkBack)

These are minor - the testing instructions provided should be sufficient for this scope of change.

---

Documentation ✅

The PR description is clear and includes:

• Detailed testing steps
• Visual before/after comparison
• Context linking to the Jira ticket (CMM-1037)

No additional documentation needed for this scope.

---

Additional Observations

1. Consistency question: I notice you updated history_list_fragment.xml to also remove its image. Are there other fragments using ActionableEmptyView with this same illustration that should be updated for consistency? A quick search might reveal other candidates.

2. Line length: The string changes are well within the 120 character limit specified in CLAUDE.md ✅

3. Design pattern: This change establishes a cleaner pattern for empty states without illustrations. Consider documenting this as a standard for future empty views if it's part of a broader design direction.

---

Final Verdict

✅ Approved - This is a solid, well-executed UI improvement. The changes are clean, purposeful, and show clear visual improvement in the screenshots. The code quality is good, and there are no security or performance concerns.

The only minor suggestion is to verify the changes look good in landscape orientation and on various screen sizes, but these are low-risk given the simplicity of the changes.

Nice work, @nbradbury! 🎉

---

[claude]

Good change! Using match_parent instead of wrap_content ensures the empty view is properly centered vertically within the available space. This matches the pattern shown in the "After" screenshot where the content is centered.

[claude]

Nice improvement to the string clarity! The new wording is more concise and active. The change from "When you make changes to your page you'll be able to see the history here" to "You'll see this page's history when you make changes to it" is clearer and more natural.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22452-15c3103
	Commit	15c3103
	Direct Download	jetpack-prototype-build-pr22452-15c3103.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22452-15c3103
	Commit	15c3103
	Direct Download	wordpress-prototype-build-pr22452-15c3103.apk

Note: Google Login is not supported on these builds.

[adalpari]