Fix Codecov PGP key fetch in coverage upload - #22963
Merged
Merged
Conversation
Codecov rotated their Keybase username from codecovsecurity to codecovsecops (the new URL serves the same key fingerprint 27034E7FDB850E0BBC2C62FF806BB28AED779869). The old URL now returns a 32-byte 404 body that curl was happily piping into gpg, breaking the import and aborting run-unit-tests.sh under `set -e` before merge_junit_reports could run. Also add `--fail --silent --show-error` so any future move surfaces as a curl failure with a clear message instead of an opaque gpg error. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
Contributor
|
|
Contributor
|
|
nbradbury
approved these changes
Jun 9, 2026
nbradbury
left a comment
nbradbury
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for the fix! 
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI was failing in the
Uploading code coveragestep becausecurl https://keybase.io/codecovsecurity/pgp_keys.ascnow returns a 32-byte HTTP 404 (SELF-SIGNED PUBLIC KEY NOT FOUND). That body gets piped intogpg --import, gpg fails with "no valid OpenPGP data found", andset -eaborts the rest of the run-unit-tests script beforemerge_junit_reportsruns — which is why later steps complain about a missingmerged-test-results.xmlartifact.Codecov (now under
SentryHarness) appears to have renamed their Keybase account fromcodecovsecuritytocodecovsecops. The new URL serves the same signing key (fingerprint27034E7FDB850E0BBC2C62FF806BB28AED779869, key IDED779869).Changes
codecovsecurity→codecovsecops.--fail --silent --show-errorto thecurlcall so the next time this URL moves, curl exits non-zero with a clear error instead of silently piping a 404 page into gpg.Same fix being applied in woocommerce-android: woocommerce/woocommerce-android#16051
Test plan
Follow-up (not in this PR)
The legacy
uploader.codecov.iois deprecated in favor of thecodecov-cliatcli.codecov.io. Worth migrating in a separate PR.🤖 Generated with Claude Code