RS unified comment detail screen

[nbradbury]

Description

This PR is the first of several to complete the abandoned Unified Comments project and update it to use wordpress-rs. Here we add the unified comment detail screen, which was never worked on by the previous team.

The unified comment detail screen supports viewing, moderation (approve/unapprove, spam, trash, delete), reply (with @-mention suggestions, full-screen expand and draft autosave), like, edit, and a copy/share more-menu — styled to match the legacy comment detail.

Known limitations (to resolve when the comment list also moves to wordpress-rs):

• A brand-new reply doesn't appear in the (FluxC) list until it's refreshed from the server.
• Liking and the edit screen stay on FluxC.

Testing instructions

Requires a WP.com or self-hosted application-password site.

Enable the feature:

1. Me → App Settings → Experimental Features

• Verify "RS Unified Comment Detail" appears (debug builds only) and enable it

Open and act on a comment:

1. My Site → Comments → tap a comment

• Verify the detail opens and shows the comment, with a readable layout and a working back arrow

2. Try Approve/Unapprove, Spam, Like, and the More menu (Edit, Trash, Copy link, Share, Delete)

• Verify each action succeeds; an approved comment shows "Approved" with an accent-colored icon

3. Trash or Spam a comment, then return to the list

• Verify the list reflects the change

4. Reply to a comment

• Verify the reply is published (replying to a pending comment also approves it)

[dangermattic]

	2 Warnings
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Android by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Android
	Build Type	Debug
	Version	pr23051-be0a6b9
	Build Number	1498
	Application ID	com.jetpack.android.prealpha
	Commit	be0a6b9
	Installation URL	0p7ngnb2j2j38

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Android by scanning the QR code below to install the corresponding build.

	App Name	WordPress Android
	Build Type	Debug
	Version	pr23051-be0a6b9
	Build Number	1498
	Application ID	org.wordpress.android.prealpha
	Commit	be0a6b9
	Installation URL	5sck660t6q7lg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[codecov]

Codecov Report

❌ Patch coverage is 64.90385% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.58%. Comparing base (46d50de) to head (be0a6b9).

Files with missing lines	Patch %	Lines
...comments/unified/UnifiedCommentDetailsViewModel.kt	73.46%	4 Missing and 35 partials ⚠️
...ndroid/ui/comments/unified/CommentsRsDataSource.kt	41.50%	31 Missing ⚠️
...org/wordpress/android/fluxc/store/CommentsStore.kt	0.00%	2 Missing ⚠️
...ava/org/wordpress/android/ui/ActivityLauncher.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk   #23051      +/-   ##
==========================================
+ Coverage   37.53%   37.58%   +0.04%     
==========================================
  Files        2327     2328       +1     
  Lines      125628   125829     +201     
  Branches    17253    17320      +67     
==========================================
+ Hits        47159    47289     +130     
- Misses      74632    74668      +36     
- Partials     3837     3872      +35     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[adalpari]

Clauide is pointing some potential bugs. Could you have a look at them and see if they are false positives?

Correctness bugs

1. Moderation during loading acts on the wrong status (silent data mutation)

UnifiedCommentDetailsFragment.kt:237 · CONFIRMED

The action footer (Approve/Spam/Like) stays visible and clickable while the comment is still loading — only the scroll view is hidden. The ViewModel handlers don't guard on loadedComment, so currentStatus() returns the default CommentStatus.ALL.

Failure: Open a TRASH or SPAM comment and tap moderate before load completes → onApproveClicked computes newStatus=APPROVED and un-trashes/un-spams the comment server-side, silently changing its status to the wrong value.

---
2. Like always fails on self-hosted app-password sites

UnifiedCommentDetailsFragment.kt:128 · CONFIRMED

The Like button is always shown, but commentsStore.likeComment() rejects non-WPCom-REST sites. This feature explicitly supports self-hosted application-password sites, where site.isUsingWpComRestApi is false.

Failure: Tap Like on a self-hosted site → likeComment returns CommentError(INVALID_INPUT, "Can't like a comment on XMLRPC API"), the optimistic flag reverts, and the user sees an error snackbar every time. Legacy CommentDetailFragment simply hid the button for these sites.

---
3. Post-title Reader opens with blogId=0 on self-hosted sites

UnifiedCommentDetailsViewModel.kt:164 (also :161) · CONFIRMED

onPostTitleClicked uses site.siteId as the Reader blog id, which is 0 for self-hosted app-password sites (supported per the class doc).

Failure: Tap the post title → OpenPostInReader(0, postId) launches the Reader with blogId=0, which can't be resolved → error/blank screen instead of the post.

---
4. Like double-tap race

UnifiedCommentDetailsViewModel.kt:134 · CONFIRMED

onLikeClicked has no in-flight guard and derives the target state from optimistic uiState.

Failure: Fast double-tap → first tap sends like=true, second reads isLiked=true and sends like=false before the first resolves. Racing requests can settle in either order, desyncing UI from server. (Note: onReplyClicked already got an in-flight guard in this PR — Like didn't.)

---
5. Approve-after-reply failure is swallowed

UnifiedCommentDetailsViewModel.kt:202 · CONFIRMED

Failure: Reply to an unapproved comment; reply succeeds, then approveAfterReply() runs moderate(APPROVED). If that returns RsResult.Error, the code silently reverts status to UNAPPROVED with no snackbar — user believes the comment was approved (legacy parity behavior) while it stays pending.

[nbradbury]

@adalpari I fixed all but #5, then updated to Fable 5 and ran a review which uncovered some more issues. Everything has been addressed so ready for round two.

[adalpari]

LGTM!