Add unit tests for the RS comments - #23090
Merged
Merged
Conversation
Restores the wordpress-rs comments-list tests that were removed to shrink the Phase 2 list PRs (#23061/#23062/#23063). Covers the list ViewModel, the rs data source, status/tab mapping, and tab modelling: 41 tests, all green against current trunk. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
nbradbury
changed the title
Contributor
|
|
Contributor
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #23090 +/- ##
==========================================
+ Coverage 37.36% 37.55% +0.18%
==========================================
Files 2340 2340
Lines 127024 127024
Branches 17517 17517
==========================================
+ Hits 47465 47705 +240
+ Misses 75672 75412 -260
- Partials 3887 3907 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Covers the CommentHtmlBody helpers introduced with the detail Compose conversion: splitCommentHtml's text/image segment boundaries (ordering, blank-segment trimming, src-less img tags) and commentHtmlToAnnotatedString's link annotation and block-whitespace trimming. Robolectric-run because both reach android.text.Html/HtmlCompat. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nbradbury
changed the title
nbradbury
changed the title
nbradbury
marked this pull request as ready for review
July 10, 2026 17:36
Drop the redundant toRsComment Hold-status test (its status delegation is already covered by CommentsRsStatusMapperTest and the field-mapping test) and return a mock for the discarded executor-stub response. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Android Lint flags mocking the uniffi PostsRequestFilterListWithViewContextResponse data class. Restore the explicit constructor for the discarded executor-stub response. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nbradbury
enabled auto-merge (squash)
July 13, 2026 10:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit-test coverage for the wordpress-rs comments experience that was missing from earlier PRs. No production code changes.
RS comments list — restores the list tests that were removed to shrink the Phase 2 list PRs (#23061 / #23062 / #23063).
Comment detail HTML body — adds Robolectric tests for the
CommentHtmlBodyparsing helpers introduced with the detail Compose conversion (#23078).Testing
./gradlew :WordPress:testWordPressDebugUnitTest --tests '*CommentsRsListViewModelTest' --tests '*CommentsRsDataSourceTest' --tests '*CommentsRsListMappingTest' --tests '*CommentsRsListTabTest' --tests '*CommentHtmlBodyTest'→ 51 passed, 0 failures.