-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Feature/3633 export site api #3848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nbradbury
merged 12 commits into
feature/delete-site-redesigned
from
feature/3633-export-site-api
Mar 11, 2016
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
23c0bdc
Revert "Revert "Merge branch 'feature/3633-export-site-api' into feat…
kwonye ea13e14
Adding strings and ifAdded check for fragments since this is a cancel…
kwonye b2ad962
Adding cancel button and converting to string values
kwonye 36f349e
Formatting
kwonye 34182fa
Using new SupportLibrary version of vector drawables
kwonye 3f341cd
Adding parenthesis
kwonye d02c304
Adding email to export message
kwonye 6d4daf3
Merge branch 'feature/delete-site-redesigned' into feature/3633-expor…
kwonye 3a6b3ca
Merge branch 'feature/delete-site-redesigned' into feature/3633-expor…
kwonye 62d2b78
Removing support library vector drawables as 23.1 doesn't support it yet
kwonye 2dcb145
No need for onClickListener
kwonye df0f442
Simplifying export content message
kwonye File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend adding
if (!NetworkUtils.checkConnection(getActivity())) return;before making the network call. Even though site settings won't appear if there's no connection, there's no guarantee that won't change, and it's possible the connection could exist when settings appears but is lost by the time the user chooses to export.