-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New .ORG login "internals" & Health-Check MVP #3853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
e70a334
Try the user inserted URL first, and check that all XML-RPC methods a…
daniloercoli b7f5958
Remove 'wp-login.php' from input URL
daniloercoli db46961
Remove junk before the xml preamble in the RSD parsing method.
daniloercoli 57ea8e6
Remove "wp-login.php" if available in the input URL, and fix other mi…
daniloercoli d4a1b91
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
daniloercoli 6ffbacf
Introduce "smart" algorithms that guess the URL of the site.
daniloercoli 6f47e4c
Always use lowercase URL. This commit needs to be double checked.
daniloercoli c87afdf
Refactoring the code that check the validity of the XML-RPC Endpoint
daniloercoli 9356320
Check for BB plugins on the server.
daniloercoli c267865
Added few more comments, and cleaned the code a bit.
daniloercoli fdab062
Refactoring.
daniloercoli 9e7fa5e
Reverting 6f47e4c5a2d0764e678e800c78f7d0ba1dbb397f - don't force the …
daniloercoli 4c00304
Better logging
daniloercoli 2f297d4
Catch Timeout error and show a detailed error mesage instead of a gen…
daniloercoli a5a6198
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
daniloercoli 4760505
Move the document with BB plugins to xmlrpc.eritreo.it.
daniloercoli 07f2341
Do not return xml-rpc endpoint found but have missing methods when th…
daniloercoli ef7a750
Correctly catch redirect errors on login, and remove the Crashlytics …
daniloercoli 60e4d23
Remove any external dependencies from the PluginsChecker. Just use An…
daniloercoli 10583c3
Download the BB plugins list from the new shiny repo on Github
daniloercoli d122b49
Move the plugins checker to the "future" folder. It's not going to be…
daniloercoli a5afb6a
Bump Analytics when the user inserts an invalid URL
daniloercoli fcf063d
Remove unused imports.
daniloercoli 7bc9296
Testable login url and runner of xplat tests
hypest 49ea8e1
Testable login url and runner of xplat tests
hypest bbf7d52
Make healthcheck test runner accept null inputUrl
hypest 16ca088
Cover the case were inputUrl is whitespace
hypest 9f87768
Removed unnecessary if statement.
daniloercoli 58a6f92
Remove padding whitespace from siteURL, test it
hypest 00b509d
Remove padding whitespace from siteURL, test it
hypest 1f3e7b1
Correctly use break instead of continue to exit a loop immediately.
daniloercoli 1db3fba
Make 'appendXMLRPCPath' more readable by using charAt instead of subs…
daniloercoli 4a72aad
Test runner for xmlrpc discovery healthcheck
hypest 66242ec
Adds an xplat test for xmlrpc discovery
hypest eeb0705
Adds an xplat test for xmlrpc discovery
hypest d861338
Test runner that can mock responses from assets
hypest c5c9da6
Add test with xmlrpc.php endpoint responding normally
hypest bff73ae
Add test with xmlrpc.php endpoint responding normally
hypest 8f93ada
Fix: replace server magic name in body assets
hypest 880dac5
Shutdown the MockWebServer between mock tests
hypest 638bfff
Test xmlrpc discovery with redirection
hypest 81db586
Test xmlrpc discovery with redirection
hypest ff22486
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
daniloercoli e0ac745
Fix an issue where the "erroneous SSL cert" flag was not set to true …
daniloercoli 6826b58
Do not track the "Invalid inserted URL" event when the user has inser…
daniloercoli 5841622
Small code re-org for readability
hypest f41462f
Move functions back to FetchBlogListWPOrg
hypest 52088e5
Merge branch 'feature/3805-improve-self-hosted-login-internals' into …
hypest a0cd889
Break down to more descriptive helper routines
hypest 2154faf
Implement serializable in PlanFeaturesHighlightSection
nbradbury 5ffdcc8
Simplified by only serializing SitePlan in fragment
nbradbury c1b7eae
Merge pull request #3857 from wordpress-mobile/issue/3855-plans-not-s…
daniloercoli fecdfc7
Rename to getUserBlogsList
hypest 661d13f
Merge branch 'develop' into feature/health-check-mvp
hypest 050e9de
Restrict healthcheck tests locale to english
hypest 20c519a
Delete the xplat source tree so to subtree-add it
hypest f63a1df
Add 'WordPress/src/androidTest/assets/health-check/' from commit '81d…
hypest fe0d671
Add subtree pull instructions in CONTIBUTING.md
hypest 37d6eef
Add comments on the black box scanner tools.
daniloercoli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
229 changes: 229 additions & 0 deletions
229
WordPress/src/androidTest/assets/health-check/health-check-xplat-testcases.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,229 @@ | ||
| { | ||
| "testcases": [ | ||
| { | ||
| "comment": "testing empty url", | ||
| "realm": "URL_CANONICALIZATION", | ||
| "setup": { | ||
| "input": { | ||
| "siteUrl": "" | ||
| }, | ||
| "output": { | ||
| "error": { | ||
| "type": "SITE_URL_CANNOT_BE_EMPTY", | ||
| "message": "Check that the site URL entered is valid" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "comment": "testing whitespace url", | ||
| "realm": "URL_CANONICALIZATION", | ||
| "setup": { | ||
| "input": { | ||
| "siteUrl": " " | ||
| }, | ||
| "output": { | ||
| "error": { | ||
| "type": "SITE_URL_CANNOT_BE_EMPTY", | ||
| "message": "Check that the site URL entered is valid" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "comment": "testing null url", | ||
| "realm": "URL_CANONICALIZATION", | ||
| "setup": { | ||
| "input": { | ||
| "siteUrl": null | ||
| }, | ||
| "output": { | ||
| "error": { | ||
| "type": "SITE_URL_CANNOT_BE_EMPTY", | ||
| "message": "Check that the site URL entered is valid" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "comment": "testing padding whitespace", | ||
| "realm": "URL_CANONICALIZATION", | ||
| "setup": { | ||
| "input": { | ||
| "siteUrl": " \t http://wordpress.com \t " | ||
| }, | ||
| "output": { | ||
| "siteUrl": "http://wordpress.com" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "comment": "testing xmlrpc.php missing", | ||
| "realm": "XMLPRC_DISCOVERY", | ||
| "setup": { | ||
| "input": { | ||
| "serverMock": [ | ||
| { | ||
| "request": { | ||
| "method": "GET", | ||
| "path": "/" | ||
| }, | ||
| "response": { | ||
| "statusCode": 404 | ||
| } | ||
| }, | ||
| { | ||
| "request": { | ||
| "method": "GET", | ||
| "path": "/xmlrpc.php" | ||
| }, | ||
| "response": { | ||
| "statusCode": 404 | ||
| } | ||
| }, | ||
| { | ||
| "request": { | ||
| "method": "POST", | ||
| "path": "/" | ||
| }, | ||
| "response": { | ||
| "statusCode": 404 | ||
| } | ||
| }, | ||
| { | ||
| "request": { | ||
| "method": "POST", | ||
| "path": "/xmlrpc.php" | ||
| }, | ||
| "response": { | ||
| "statusCode": 404 | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "output": { | ||
| "error": { | ||
| "type": "XMLRPC_MISSING", | ||
| "message": "Couldn't connect to the WordPress site" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "comment": "testing xmlrpc.php found", | ||
| "realm": "XMLPRC_DISCOVERY", | ||
| "setup": { | ||
| "input": { | ||
| "serverMock": [ | ||
| { | ||
| "request": { | ||
| "method": "POST", | ||
| "path": "/xmlrpc.php" | ||
| }, | ||
| "response": { | ||
| "statusCode": 200, | ||
| "body": "asset:listMethodsResponse.xml" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "output": { | ||
| "xmlrpcEndpoint": "http://mockserver/xmlrpc.php" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "comment": "testing xmlrpc.php discovered after redirect", | ||
| "realm": "XMLPRC_DISCOVERY", | ||
| "setup": { | ||
| "input": { | ||
| "siteUrl": "http://mockserver/wp", | ||
| "serverMock": [ | ||
| { | ||
| "request": { | ||
| "method": "GET", | ||
| "path": "/wp" | ||
| }, | ||
| "response": { | ||
| "statusCode": 301, | ||
| "headers": { | ||
| "Location": "/wpnew/" | ||
| }, | ||
| "body": "Page has moved!" | ||
| } | ||
| }, | ||
| { | ||
| "request": { | ||
| "method": "POST", | ||
| "path": "/wp" | ||
| }, | ||
| "response": { | ||
| "statusCode": 307, | ||
| "headers": { | ||
| "Location": "/wpnew/" | ||
| }, | ||
| "body": "Page has moved! POST to new address!" | ||
| } | ||
| }, | ||
| { | ||
| "request": { | ||
| "method": "POST", | ||
| "path": "/wp/xmlrpc.php" | ||
| }, | ||
| "response": { | ||
| "statusCode": 307, | ||
| "headers": { | ||
| "Location": "/wpnew/xmlrpc.php" | ||
| }, | ||
| "body": "Page has moved! POST to new address!" | ||
| } | ||
| }, | ||
| { | ||
| "request": { | ||
| "method": "GET", | ||
| "path": "/wpnew/" | ||
| }, | ||
| "response": { | ||
| "statusCode": 200, | ||
| "body": "asset:index_with_redirect.html" | ||
| } | ||
| }, | ||
| { | ||
| "request": { | ||
| "method": "GET", | ||
| "path": "/wpnew/xmlrpc.php?rsd" | ||
| }, | ||
| "response": { | ||
| "statusCode": 200, | ||
| "body": "asset:rsd_with_redirect.xml" | ||
| } | ||
| }, | ||
| { | ||
| "request": { | ||
| "method": "GET", | ||
| "path": "/wpnew/xmlrpc.php" | ||
| }, | ||
| "response": { | ||
| "statusCode": 405, | ||
| "body": "XML-RPC server accepts POST requests only." | ||
| } | ||
| }, | ||
| { | ||
| "request": { | ||
| "method": "POST", | ||
| "path": "/wpnew/xmlrpc.php" | ||
| }, | ||
| "response": { | ||
| "statusCode": 200, | ||
| "body": "asset:listMethodsResponse.xml" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "output": { | ||
| "xmlrpcEndpoint": "http://mockserver/wpnew/xmlrpc.php" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should list other subtrees and just give the generic command to pull / push