-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Plans] Integrate Google Store calls, and synch IAP with backend - step one #4078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
2341d26
Use our logger in IabHelper
daniloercoli 9cda45d
Start integrating the store calls
daniloercoli db846cf
Re-synch purchases with wpcom server on startup and periodically. (Th…
daniloercoli eecf66f
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
daniloercoli 443d963
Remove unused imports.
daniloercoli 8f553c9
Remove custom hardcoded SKUs since REST Endpoint has been updated.
daniloercoli 2b9d5a6
Fix log message
daniloercoli 63ef93b
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
daniloercoli 6be91fa
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
daniloercoli 3835ec3
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
daniloercoli 691e6a8
Use the new endpoint name, and remove unused parameters.
daniloercoli cc3c871
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
daniloercoli 569e2b0
Change the label to "upgrade" when the selected blog already has a pl…
daniloercoli 9cfa151
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
daniloercoli 20c7335
Remove links to unused subprojects used during development
daniloercoli 27765fb
Revert unwanted commits
daniloercoli ef9b80d
Fix merge conflicts
daniloercoli 97baa8c
Fix merge conflicts - tentative #2
daniloercoli 7c28243
New plans strings
daniloercoli 90e71a4
Do not show the Upgrade|Purchase button when the blog already has a p…
daniloercoli e6ce503
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
daniloercoli 877b460
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
daniloercoli bdba660
Make sure `mIabHelper` has finished its setup before doing any calls …
daniloercoli 948c6be
Use constants defined in PlanConstants.java when checking for `planID`
daniloercoli 795c213
Remove unused constants.
daniloercoli f48f9f7
Synch IAPs with the backend when there is a pending request only. Do …
daniloercoli 858cfa8
Change the visibilty of `mContext` to private in UpdateIAPTask
daniloercoli d0d361e
Drop unused variable
daniloercoli 70d4012
Added a comment that describe how the sync with wpcom works
daniloercoli 84932ae
Revert changes made to IabHelper
daniloercoli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this app setting necessary? Seems like we could drop it and remove the call to
PlansUtils.synchIAPsWordPressCom()that's done here.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to synch the purchase with the wpcom backend as soon as it's made on the Google Store. So the product is enabled on the site immediately after.
That app setting, and the call that happens when the app is brought in foreground, are there for security reasons. If something bad happens during the post purchase synch, we will re-synch it later. Without this initial synch the backend doesn't have any info about the purchase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, that makes sense. It would a good idea to add a comment stating this purpose, though, since it's unclear otherwise.