Skip to content

People management analytics #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniloercoli merged 3 commits into from
May 26, 2016
Merged

People management analytics #4128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f89c576
People management event names added
oguzkocer May 26, 2016
07b3957
People management events tracked
oguzkocer May 26, 2016
68381f0
Renamed OPENED_PERSON as OPENED_PEOPLE_MANAGEMENT
oguzkocer May 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WordPress/src/main/java/org/wordpress/android/ui/ActivityLauncher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public static void viewCurrentBlogThemes(Context context) {
public static void viewCurrentBlogPeople(Context context) {
Intent intent = new Intent(context, PeopleManagementActivity.class);
slideInFromRight(context, intent);
// TODO: add -> AnalyticsTracker.track(AnalyticsTracker.Stat.OPENED_PEOPLE_MANAGEMENT);
AnalyticsUtils.trackWithCurrentBlogDetails(AnalyticsTracker.Stat.OPENED_PEOPLE_MANAGEMENT);
}

public static void viewBlogSettingsForResult(Activity activity, Blog blog) {
Expand Down
5 changes: 5 additions & 0 deletions WordPress/src/main/java/org/wordpress/android/ui/people/PeopleManagementActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,13 @@

import org.wordpress.android.R;
import org.wordpress.android.WordPress;
import org.wordpress.android.analytics.AnalyticsTracker;
import org.wordpress.android.datasets.PeopleTable;
import org.wordpress.android.models.Blog;
import org.wordpress.android.models.Person;
import org.wordpress.android.ui.ActivityLauncher;
import org.wordpress.android.ui.people.utils.PeopleUtils;
import org.wordpress.android.util.AnalyticsUtils;
import org.wordpress.android.util.ToastUtils;

import java.util.List;
Expand Down Expand Up @@ -116,6 +118,7 @@ public void onPersonSelected(Person person) {
personDetailFragment.setPersonDetails(personID, localTableBlogID);
}
if (!personDetailFragment.isAdded()) {
AnalyticsUtils.trackWithCurrentBlogDetails(AnalyticsTracker.Stat.OPENED_PERSON);
FragmentTransaction fragmentTransaction = getFragmentManager().beginTransaction();
fragmentTransaction.add(R.id.fragment_container, personDetailFragment, KEY_PERSON_DETAIL_FRAGMENT);
fragmentTransaction.addToBackStack(null);
Expand Down Expand Up @@ -143,6 +146,7 @@ public void onRoleChanged(long personID, int localTableBlogId, String newRole) {
new PeopleUtils.UpdateUserCallback() {
@Override
public void onSuccess(Person person) {
AnalyticsUtils.trackWithCurrentBlogDetails(AnalyticsTracker.Stat.PERSON_UPDATED);
PeopleTable.save(person);
refreshOnScreenFragmentDetails();
}
Expand Down Expand Up @@ -190,6 +194,7 @@ private void removeSelectedPerson() {
new PeopleUtils.RemoveUserCallback() {
@Override
public void onSuccess(long personID, int localTableBlogId) {
AnalyticsUtils.trackWithCurrentBlogDetails(AnalyticsTracker.Stat.PERSON_REMOVED);
// remove the person from db, navigate back to list fragment and refresh it
Person person = PeopleTable.getPerson(personID, localTableBlogId);
String text;
Expand Down
4 changes: 4 additions & 0 deletions ...cs/WordPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTracker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ public enum Stat {
OPENED_ACCOUNT_SETTINGS,
OPENED_APP_SETTINGS,
OPENED_MY_PROFILE,
OPENED_PEOPLE_MANAGEMENT,
OPENED_PERSON,
CREATED_ACCOUNT,
ACCOUNT_LOGOUT,
SHARED_ITEM,
Expand All @@ -134,6 +136,8 @@ public enum Stat {
LOGIN_INSERTED_INVALID_URL,
LOGIN_AUTOFILL_CREDENTIALS_FILLED,
LOGIN_AUTOFILL_CREDENTIALS_UPDATED,
PERSON_REMOVED,
PERSON_UPDATED,
PUSH_AUTHENTICATION_APPROVED,
PUSH_AUTHENTICATION_EXPIRED,
PUSH_AUTHENTICATION_FAILED,
Expand Down
16 changes: 16 additions & 0 deletions ...ressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTrackerMixpanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,6 +651,14 @@ private AnalyticsTrackerMixpanelInstructionsForStat instructionsForStat(
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("Me - Opened My Profile");
break;
case OPENED_PEOPLE_MANAGEMENT:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("People Management - Accessed List");
break;
case OPENED_PERSON:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("People Management - Accessed Details");
break;
case CREATED_ACCOUNT:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("Created Account");
Expand Down Expand Up @@ -822,6 +830,14 @@ private AnalyticsTrackerMixpanelInstructionsForStat instructionsForStat(
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("Login - Auto Fill Credentials Updated");
break;
case PERSON_REMOVED:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("People Management - Removed Person");
break;
case PERSON_UPDATED:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("People Management - Updated Person");
break;
case PUSH_AUTHENTICATION_APPROVED:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("Push Authentication - Approved");
Expand Down
12 changes: 12 additions & 0 deletions ...dPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTrackerNosara.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,12 @@ public void track(AnalyticsTracker.Stat stat, Map<String, ?> properties) {
case OPENED_MY_PROFILE:
eventName = "my_profile_opened";
break;
case OPENED_PEOPLE_MANAGEMENT:
eventName = "people_management_list_opened";
break;
case OPENED_PERSON:
eventName = "people_management_details_opened";
break;
case CREATED_ACCOUNT:
eventName = "account_created";
break;
Expand Down Expand Up @@ -393,6 +399,12 @@ public void track(AnalyticsTracker.Stat stat, Map<String, ?> properties) {
case LOGIN_AUTOFILL_CREDENTIALS_UPDATED:
eventName = "login_autofill_credentials_updated";
break;
case PERSON_REMOVED:
eventName = "people_management_person_removed";
break;
case PERSON_UPDATED:
eventName = "people_management_person_updated";
break;
case PUSH_AUTHENTICATION_APPROVED:
eventName = "push_authentication_approved";
break;
Expand Down