Skip to content

Issue/4438 pn read signal clear all - #4444

Merged
kwonye merged 4 commits into
developfrom
issue/4438-pn-read-signal-clear-all
Aug 11, 2016
Merged

Issue/4438 pn read signal clear all#4444
kwonye merged 4 commits into
developfrom
issue/4438-pn-read-signal-clear-all

Conversation

@mzorz

@mzorz mzorz commented Jul 28, 2016

Copy link
Copy Markdown
Contributor

Fixes #4438

To test:
This needs the backend counterpart to test, but basically:

  1. log in with your account on an iOS and an Android device, as well as the web client on a browser.
  2. have some other account like/comment/etc one of your posts
  3. you'd receive push notifications about this action on both your iOS and Android devices - don't open them or do anything there yet, just observe this.
  4. open the Notifications TAB on the web client
  5. the notifications on both iOS and Android devices should be cleared.

Needs review: @kwonye

@kwonye kwonye self-assigned this Aug 1, 2016
@kwonye kwonye added this to the 5.8 milestone Aug 3, 2016
@kwonye

kwonye commented Aug 3, 2016

Copy link
Copy Markdown
Contributor
  1. the notifications on both iOS and Android devices should be cleared

Just want to clarify... Is this possible on iOS? From what I understand iOS doesn't support updating current notifications until iOS 10.

@mzorz

mzorz commented Aug 3, 2016

Copy link
Copy Markdown
Contributor Author
  1. the notifications on both iOS and Android devices should be cleared
    Just want to clarify... Is this possible on iOS? From what I understand iOS doesn't support updating current notifications until iOS 10.

That's right - what iOS is doing is clearing the badge (thus the original name for that PN in the backend, which type is called badge-reset). Thanks for bringing this up @kwonye

@mzorz mzorz modified the milestones: 5.7, 5.8 Aug 9, 2016
@mzorz mzorz modified the milestones: 5.8, 5.7 Aug 9, 2016
@kwonye

kwonye commented Aug 11, 2016

Copy link
Copy Markdown
Contributor

Works great! :shipit:

@kwonye
kwonye merged commit 5396d62 into develop Aug 11, 2016
@kwonye
kwonye deleted the issue/4438-pn-read-signal-clear-all branch August 11, 2016 21:00
@mzorz

mzorz commented Aug 11, 2016

Copy link
Copy Markdown
Contributor Author

Yay!

On Aug 11, 2016 6:00 PM, "Will Kwon" notifications@github.com wrote:

Works great!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants