Issue/4438 pn read signal clear all - #4444
Merged
Merged
Conversation
3 tasks
Contributor
Just want to clarify... Is this possible on iOS? From what I understand iOS doesn't support updating current notifications until iOS 10. |
Contributor
Author
That's right - what iOS is doing is clearing the badge (thus the original name for that PN in the backend, which type is called |
Contributor
|
Works great! |
Contributor
Author
|
Yay! On Aug 11, 2016 6:00 PM, "Will Kwon" notifications@github.com wrote:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4438
To test:
This needs the backend counterpart to test, but basically:
Needs review: @kwonye