-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Issue/4462 reader traintracks #4540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
46be47c
Added TRAIN_TRACKS_RENDER and TRAIN_TRACKS_INTERACT to AnalyticsTracker
nbradbury 4b24e11
Added AnalyticsRailcar model
nbradbury 5b5082e
Added TRAIN_TRACKS_RENDER and TRAIN_TRACKS_INTERACT to nosara tracker
nbradbury 5bbf9be
Added TRAIN_TRACKS_RENDER and TRAIN_TRACKS_INTERACT to mixpanel tracker
nbradbury 5de0541
Moved model, added trackWithRailcar
nbradbury de05d9d
Changed AnalyticsRailcar to never return null for String getters
nbradbury 1aeda0c
Added railcarJson to ReaderPost model
nbradbury 14a9b02
Added railcar_json to post table
nbradbury a1c50c2
Include railcar if it exists when tracking reader post details
nbradbury 5130313
Removed AnalyticsRailcar model
nbradbury 1ceefab
Only track railcar for interact/render events
nbradbury 338d704
Track TRAIN_TRACKS_RENDER when a post with a railcar is rendered
nbradbury dd045b5
Added trackRailcarInteract(), required changing AnalyticsTrackerNosar…
nbradbury 5163039
Call trackRailcarInteract when tracking reader post event
nbradbury 4a0dfaa
Use trackWithReaderPostDetails when tracking a post being liked/unliked
nbradbury 2a36994
Use trackWithReaderPostDetails when tracking a search result being ta…
nbradbury 86e9551
Removed unused canTrackRailcarInteract from trackWithBlogDetails
nbradbury 27518d3
Use HashSet to store rendered post IDs
nbradbury e0eeb42
Renamed "Interact" to "Interaction"
nbradbury File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any performance impact here? I'm assuming it's really lightweight json objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they're fairly lightweight. Here's an example from a post returned by
/v1.2/read/search/?q=android: