Issue/460editor content loss - #4927
Merged
Merged
Conversation
aforcier
reviewed
Dec 16, 2016
| getTitle(); | ||
| getContent(); | ||
| } catch (IllegalEditorStateException e) { | ||
| AppLog.e(T.EDITOR, "toggleHtmlMode: unable to get title or content"); |
Contributor
There was a problem hiding this comment.
We also need to reset the toggle button state here with toggleButton.setChecked(false), otherwise it's left in a pressed state and might cause content loss issues when pressed again (as the HTML -> visual flow is triggered).
Contributor
|
The instrumentation tests are currently failing as |
Contributor
|
Looks good! Hope this solves the problem. Left a few comments, should be good to go with those addressed. |
Contributor
Author
|
@aforcier ready for another pass. |
aforcier
reviewed
Dec 16, 2016
Contributor
There was a problem hiding this comment.
This needs to be wrapped in a getActivity().runOnUiThread(...).
maxme
force-pushed
the
issue/460editor-content-loss
branch
from
December 16, 2016 16:04
ad163ab to
e3baf0f
Compare
Contributor
|
|
Contributor
Author
|
Cherry picked in |
This was referenced Jan 21, 2017
malinajirka
added a commit
that referenced
this pull request
Sep 29, 2020
60e13dd828 Merge pull request #461 from wordpress-mobile/travis-25 6b4f78a59c Update example app to API 25 3d0a8c8fcc Update Travis to use API25 5cafc2f59a Merge branch 'develop' of https://github.com/wordpress-mobile/WordPress-Android into develop c5023cca1c Fix EditorFragmentTest after adding getContent exception throw 702a7241c5 Fix an issue in the Hybrid editor that could lead to an empty post title and content on save fead4827bb Merge pull request #4927 from wordpress-mobile/issue/460editor-content-loss a9ae13d377 Fix EditorFragmentTest after adding getContent exception throw 93a6017bd1 Fix an issue in the Hybrid editor that could lead to an empty post title and content on save 2069d60cbf Updating grade plugin c5ee8a976e Upgrade to Support Lib, build tools v25.0.1 141e508e98 Updating build tools and compile/targetSDK to 25 along with support libraries b6f8331feb update missing build files to 2.2.2 f36efa05b9 Updated to gradle v2.2.2 8a0b518157 Update to Android Gradle Plugin 2.2.1 git-subtree-dir: libs/editor git-subtree-split: 60e13dd828824b308252c9842d9c459db26a9f56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/WordPress-Editor-Android#460
I also removed some old code (quick pic/video handler) that could lead to post deletion when the user comes back from the media picker.