Skip to content

Issue/5877 aztec tracking #5879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hypest merged 2 commits into from
May 17, 2017
Merged

Issue/5877 aztec tracking #5879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1e19a1
Rename tracking variables to better distinguish visual editor from Aztec
0nko May 11, 2017
a15ffc5
Add missing Aztec analytics descriptors
0nko May 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions WordPress/src/main/java/org/wordpress/android/ui/prefs/AppPrefs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,13 +422,13 @@ public static boolean isAztecEditorAvailable() {
// Visual Editor
public static void setVisualEditorEnabled(boolean visualEditorEnabled) {
setBoolean(DeletablePrefKey.VISUAL_EDITOR_ENABLED, visualEditorEnabled);
AnalyticsTracker.track(visualEditorEnabled ? Stat.EDITOR_TOGGLED_ON : Stat.EDITOR_TOGGLED_OFF);
AnalyticsTracker.track(visualEditorEnabled ? Stat.EDITOR_HYBRID_TOGGLED_ON : Stat.EDITOR_HYBRID_TOGGLED_OFF);
}

public static void setVisualEditorAvailable(boolean visualEditorAvailable) {
setBoolean(UndeletablePrefKey.VISUAL_EDITOR_AVAILABLE, visualEditorAvailable);
if (visualEditorAvailable) {
AnalyticsTracker.track(Stat.EDITOR_ENABLED_NEW_VERSION);
AnalyticsTracker.track(Stat.EDITOR_HYBRID_ENABLED);
}
}

Expand Down
6 changes: 3 additions & 3 deletions ...cs/WordPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTracker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,9 @@ public enum Stat {
EDITOR_SAVED_DRAFT,
EDITOR_DISCARDED_CHANGES,
EDITOR_EDITED_IMAGE, // Visual editor only
EDITOR_ENABLED_NEW_VERSION, // Visual editor only
EDITOR_TOGGLED_OFF, // Visual editor only
EDITOR_TOGGLED_ON, // Visual editor only
EDITOR_HYBRID_ENABLED, // Visual editor only
EDITOR_HYBRID_TOGGLED_OFF, // Visual editor only
EDITOR_HYBRID_TOGGLED_ON, // Visual editor only
EDITOR_UPLOAD_MEDIA_FAILED, // Visual editor only
EDITOR_UPLOAD_MEDIA_RETRIED, // Visual editor only
EDITOR_TAPPED_BLOCKQUOTE,
Expand Down
33 changes: 24 additions & 9 deletions ...ressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTrackerMixpanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,20 +510,35 @@ private AnalyticsTrackerMixpanelInstructionsForStat instructionsForStat(Analytic
instructions.setSuperPropertyAndPeoplePropertyToIncrement("number_of_times_editor_edited_image");
instructions.setCurrentDateForPeopleProperty("last_time_edited_image");
break;
case EDITOR_ENABLED_NEW_VERSION:
case EDITOR_HYBRID_ENABLED:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("Editor - Enabled New Version");
instructions.addSuperPropertyToFlag("enabled_new_editor");
mixpanelInstructionsForEventName("Editor - Enabled Hybrid Editor");
instructions.addSuperPropertyToFlag("enabled_hybrid_editor");
break;
case EDITOR_TOGGLED_ON:
case EDITOR_HYBRID_TOGGLED_ON:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("Editor - Toggled New Editor On");
instructions.setPeoplePropertyToValue("enabled_new_editor", true);
mixpanelInstructionsForEventName("Editor - Toggled Hybrid Editor On");
instructions.setPeoplePropertyToValue("enabled_hybrid_editor", true);
break;
case EDITOR_TOGGLED_OFF:
case EDITOR_HYBRID_TOGGLED_OFF:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("Editor - Toggled New Editor Off");
instructions.setPeoplePropertyToValue("enabled_new_editor", false);
mixpanelInstructionsForEventName("Editor - Toggled Hybrid Editor Off");
instructions.setPeoplePropertyToValue("enabled_hybrid_editor", false);
break;
case EDITOR_AZTEC_ENABLED:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("Editor - Enabled Aztec Editor");
instructions.addSuperPropertyToFlag("enabled_aztec_editor");
break;
case EDITOR_AZTEC_TOGGLED_ON:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("Editor - Toggled Aztec Editor On");
instructions.setPeoplePropertyToValue("enabled_aztec_editor", true);
break;
case EDITOR_AZTEC_TOGGLED_OFF:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("Editor - Toggled Aztec Editor Off");
instructions.setPeoplePropertyToValue("enabled_aztec_editor", false);
break;
case EDITOR_UPLOAD_MEDIA_FAILED:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
Expand Down
18 changes: 12 additions & 6 deletions ...dPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTrackerNosara.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,12 +360,18 @@ public static String getEventNameForStat(AnalyticsTracker.Stat stat) {
return "editor_discarded_changes";
case EDITOR_EDITED_IMAGE:
return "editor_image_edited";
case EDITOR_ENABLED_NEW_VERSION:
return "editor_enabled_new_version";
case EDITOR_TOGGLED_OFF:
return "editor_toggled_off";
case EDITOR_TOGGLED_ON:
return "editor_toggled_on";
case EDITOR_HYBRID_ENABLED:
return "editor_hybrid_enabled";
case EDITOR_HYBRID_TOGGLED_OFF:
return "editor_hybrid_toggled_off";
case EDITOR_HYBRID_TOGGLED_ON:
return "editor_hybrid_toggled_on";
case EDITOR_AZTEC_ENABLED:
return "editor_aztec_enabled";
case EDITOR_AZTEC_TOGGLED_OFF:
return "editor_aztec_toggled_off";
case EDITOR_AZTEC_TOGGLED_ON:
return "editor_aztec_toggled_on";
case EDITOR_UPLOAD_MEDIA_FAILED:
return "editor_upload_media_failed";
case EDITOR_UPLOAD_MEDIA_RETRIED:
Expand Down