Context instead of Activity in SiteSettingsInterface - #6823
Merged
Conversation
This way, SiteSettingsInterface can be used by Services as well.
Merged
nbradbury
reviewed
Nov 4, 2017
| siteSettingsPreferences(mActivity).edit().putString(LANGUAGE_PREF_KEY, mSettings.language).apply(); | ||
| siteSettingsPreferences(mActivity).edit().putInt(DEF_CATEGORY_PREF_KEY, mSettings.defaultCategory).apply(); | ||
| siteSettingsPreferences(mActivity).edit().putString(DEF_FORMAT_PREF_KEY, mSettings.defaultPostFormat).apply(); | ||
| siteSettingsPreferences(mContext).edit().putString(LANGUAGE_PREF_KEY, mSettings.language).apply(); |
Contributor
There was a problem hiding this comment.
I know this is pre-existing code, but how about using the builder pattern here?
siteSettingsPreferences(mContext).edit()
.putString(LANGUAGE_PREF_KEY, mSettings.language)
.putInt(DEF_CATEGORY_PREF_KEY, mSettings.defaultCategory)
.putString(DEF_FORMAT_PREF_KEY, mSettings.defaultPostFormat)
.apply();
nbradbury
reviewed
Nov 4, 2017
| protected void notifyFetchErrorOnUiThread(final Exception error) { | ||
| if (mActivity == null || mActivity.isFinishing() || mListener == null) { | ||
| if (mContext == null | ||
| || (mContext instanceof Activity && ((Activity) mContext).isFinishing()) |
Contributor
There was a problem hiding this comment.
Do we really need to check isFinishing() here? That seems like something the caller should deal with.
Contributor
Author
There was a problem hiding this comment.
I was only adapting the existing code without changing the logic and yeah, that check is awkward. I removed it with 0247fd6, letting the listener decide whether the Activity (if any) needs to be checked for finishing. It seems that almost all listeners are already checking for isAdded so, no new checks are needed.
Is that what you had in mind @nbradbury ?
Contributor
Author
|
I addressed your comments @nbradbury , ready for another pass, thanks! |
Contributor
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, SiteSettingsInterface can be used by Services as well.
No new functionality added.
To test: