Skip to content

Use global scope for global operation in insights management #9742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malinajirka merged 1 commit into from
Apr 29, 2019
Merged

Use global scope for global operation in insights management #9742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...ndroid/ui/stats/refresh/lists/sections/insights/management/InsightsManagementViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import android.arch.lifecycle.LiveData
import android.arch.lifecycle.MutableLiveData
import androidx.annotation.StringRes
import kotlinx.coroutines.CoroutineDispatcher
import kotlinx.coroutines.GlobalScope
import kotlinx.coroutines.launch
import org.wordpress.android.R
import org.wordpress.android.fluxc.store.StatsStore
Expand Down Expand Up @@ -74,11 +75,12 @@ class InsightsManagementViewModel @Inject constructor(
}

fun onSaveInsights() {
launch {
// This has to be GlobalScope because otherwise the coroutine gets killed with the ViewModel
GlobalScope.launch {
val addedTypes = insights.filter { it.type == ADDED }.map { it.insightType }
statsStore.updateTypes(siteProvider.siteModel, addedTypes)

insightsUseCase.refreshData(true)
insightsUseCase.loadData()
}
_closeInsightsManagement.call()
}
Expand Down