Skip to content

Fix './gradlew build' in libs/mocks - #9972

Merged
loremattei merged 1 commit into
release/12.5from
fix/mocks-build
Jun 4, 2019
Merged

Fix './gradlew build' in libs/mocks#9972
loremattei merged 1 commit into
release/12.5from
fix/mocks-build

Conversation

@jtreanor

@jtreanor jtreanor commented Jun 4, 2019

Copy link
Copy Markdown
Contributor

The InvalidPackage lint error is causing ./gradlew build to fail due to WireMock including some libraries that are not designed for Android. We can safely ignore these errors as our WireMock setup works fine on Android.

To test:

  • cd libs/mocks && ./gradlew build

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@jtreanor jtreanor added this to the 12.5 milestone Jun 4, 2019
@jtreanor
jtreanor requested a review from loremattei June 4, 2019 08:32

@loremattei loremattei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

:shipit:

@loremattei
loremattei merged commit e5aaca1 into release/12.5 Jun 4, 2019
@loremattei
loremattei deleted the fix/mocks-build branch June 4, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants