Android x migration - #19
Conversation
|
This build is failing due to two reasons
I'm closing this PR as I think it makes more sense if we perform the migration in the app repo and push the changes here. Feel free to re-open it if you think we should rather merge the changes here. |
|
@malinajirka that makes sense. Do 'the app repo', do you mean WooAndroid or WPAndroid? IIRC the original plan was to do libraries -> WooAndroid -> WPAndroid, so if we want to make the subtree changes inside an app it might work out better to do it from WooAndroid. But as long as a feature branch is used in this repo it's probably fine. Also, there was an issue updating to Gradle plugin |
I meant whichever is migrated first:P. But it makes sense to proceed with WooAndroid migration first.
Good point. I'll make sure to test it. |
This PR replaces SupportLibrary with AndroidX.
I simply used the AS migration tool. The only thing I had to do manually was adding
androidxnamespace toCheckstyle.xml+Project.xmland reorder the imports.Merge instructions (please cross off completed steps)
Wait until issue/glide-4.9 #17 is merged.developintomaster-android-xmaster-android-xgit subtree pull --prefix=libs/login git@github.com:wordpress-mobile/WordPress-Login-Flow-Android.git master-android-x --squash)master-android-xtodevelopwhich can be merge when both WPAndroid and WCAndroid are migrated to AndroidX