Skip to content

Review oclint failure in PR 3308. #3340

Description

@diegoreymendez

Review the following oclint failures in PR 3308:

PS: as a side note there's some doubt as to why they triggered in that PR, so we decided to treat this as a separate issue.

/Users/travis/build/wordpress-mobile/WordPress-iOS/WordPress/Classes/Models/Blog.m:286:9: collapsible if statements P3 
/Users/travis/build/wordpress-mobile/WordPress-iOS/WordPress/Classes/Models/Blog.m:67:5: ivar assignment outside accessors or init P2 
/Users/travis/build/wordpress-mobile/WordPress-iOS/WordPress/Classes/Models/Blog.m:68:5: ivar assignment outside accessors or init P2 
/Users/travis/build/wordpress-mobile/WordPress-iOS/WordPress/Classes/Models/Blog.m:301:6: ivar assignment outside accessors or init P2 
/Users/travis/build/wordpress-mobile/WordPress-iOS/WordPress/Classes/Models/Blog.m:304:6: ivar assignment outside accessors or init P2 
/Users/travis/build/wordpress-mobile/WordPress-iOS/WordPress/Classes/Models/Blog.m:16:1: too many methods P3 Objective-C implementation with 32 methods exceeds limit of 30
/Users/travis/build/wordpress-mobile/WordPress-iOS/WordPress/Classes/Networking/PostServiceRemoteXMLRPC.m:111:1: high cyclomatic complexity P2 Cyclomatic Complexity Number 11 exceeds limit of 10
/Users/travis/build/wordpress-mobile/WordPress-iOS/WordPress/Classes/Networking/PostServiceRemoteXMLRPC.m:231:1: high cyclomatic complexity P2 Cyclomatic Complexity Number 12 exceeds limit of 10
/Users/travis/build/wordpress-mobile/WordPress-iOS/WordPress/Classes/Networking/PostServiceRemoteXMLRPC.m:231:1: high ncss method P2 Method of 35 non-commenting source statements exceeds limit of 30
/Users/travis/build/wordpress-mobile/WordPress-iOS/WordPress/Classes/Networking/PostServiceRemoteXMLRPC.m:231:1: high npath complexity P2 NPath Complexity Number 320 exceeds limit of 200
/Users/travis/build/wordpress-mobile/WordPress-iOS/WordPress/Classes/Networking/PostServiceRemoteXMLRPC.m:272:9: replace with object subscripting P3 
/Users/travis/build/wordpress-mobile/WordPress-iOS/WordPress/Classes/Networking/PostServiceRemoteXMLRPC.m:276:9: replace with object subscripting P3 
/Users/travis/build/wordpress-mobile/WordPress-iOS/WordPress/Classes/Networking/PostServiceRemoteXMLRPC.m:284:9: replace with object subscripting P3 
/Users/travis/build/wordpress-mobile/WordPress-iOS/WordPress/Classes/Networking/PostServiceRemoteXMLRPC.m:286:5: replace with object subscripting P3 
/Users/travis/build/wordpress-mobile/WordPress-iOS/WordPress/Classes/Models/WPAccount.m:47:5: ivar assignment outside accessors or init P2 
/Users/travis/build/wordpress-mobile/WordPress-iOS/WordPress/Classes/Models/WPAccount.m:48:5: ivar assignment outside accessors or init P2 

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions