[Stats Refresh] Add Insights Tags and Categories card - #10831
Merged
ScoutHarris merged 23 commits intoJan 17, 2019
Conversation
…0744-insights_tags_and_categories
…0744-insights_tags_and_categories
…itles and View more when necessary.
…ue. Using this for the Tags & Categories data bar and display value.
…s where the value is provided as a String.
…ctoring existing cards to use them.
Contributor
Generated by 🚫 Danger |
Contributor
Author
jklausa
approved these changes
Jan 17, 2019
jklausa
left a comment
jklausa
left a comment
Contributor
There was a problem hiding this comment.
The changes here look good! I've noticed two unrelated things though:
- The issue with avatars disappearing seems to still be an problem:
- Emojis in post titles here get messed up
|
|
||
| let numberOfDataRows = dataRows.count | ||
|
|
||
| if numberOfDataRows == 0 { |
Contributor
There was a problem hiding this comment.
nitpick and my personal style thing, but this could be written as a guard to ensure we don't accidentally forget to escape the scope when this gets modified in the future :)
Contributor
Author
There was a problem hiding this comment.
Good catch! And done!
|
Look great @ScoutHarris thanks! |
Contributor
Author
|
@jklausa thanks for noticing those two issues. I'll be sure to look at them. |
|
Just noticed one thing on the screenshots @ScoutHarris , the "Most Popular Day and Hour" block doesn't have the table headings |
45 tasks
Contributor
Author
|
@SylvesterWilmott oooohhh! Good catch! Thanks! |
79 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10744
This primarily adds the Insights Tags and Categories card.
Secondarily, it also includes:
UITableViewCellcode.Disclaimer:
To test:
Tags and Categories:
No Tags and Categories:
No data yetrow.Now with abbreviated totals!
Example:
