Integrated updates to both WordPressKit and WordPressAuthenticator - #10916
Merged
2 commits merged intoJan 31, 2019
Merged
Conversation
ghost
added
the
Author
|
At the moment, Circle CI is failing with this error:
|
Author
|
@frosty if you have a moment, would be interested in checking out this PR, which propagates the locale-handling change we introduced to |
Contributor
|
@stevebaranski I restarted Circle and it's passing now 👍 |
frosty
approved these changes
Jan 31, 2019
frosty
left a comment
frosty
left a comment
Contributor
There was a problem hiding this comment.
✅ Builds and tests pass
✅ Smoke tested the app in multiple languages – looks good!
ghost
deleted the
pods/update-wpkit-wpauth
branch
January 31, 2019 13:34
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagates the fix for this issue in
WordPressKitto WPiOS. Because this was an update to the major version, a corresponding update toWordPressAuthenticatorwas also required.Testing
Checkout the branch and confirm that existing tests pass.
To test:
Update release notes:
RELEASE-NOTES.txt.