[Stats Refresh] Period Referrers: fix displaying details view - #11741
Merged
Conversation
…matter the image type (downloaded, gridicon, etc) it will be the correct size for the stat.
…DetailExpandableRow for parent rows and DetailExpandableChildRow for child rows.
45 tasks
ghost
reviewed
May 21, 2019
| if let iconURL = rowData.userIconURL { | ||
| imageWidthConstraint.constant = Constants.userImageSize | ||
| imageView.layer.cornerRadius = Constants.userImageSize * 0.5 | ||
| imageView.layer.cornerRadius = imageSize * 0.5 |
There was a problem hiding this comment.
I know this code was in place previously, but it occurred to me that some might not understand the intent of this message.
If we're making the image view circular, it might be more clear to set the path for a mask via one of the following methods:
init(arcCenter:radius:startAngle:endAngle:clockwise:)init(ovalIn:)
I don't feel strongly about this, but wanted to share.
ghost
approved these changes
May 21, 2019
ghost
left a comment
There was a problem hiding this comment.
@ScoutHarris this is working as described for me! ![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #11360, #11080
This changes Period > Referrers to use
UITableViewCells instead of oneUIStackView.Previously, all the data was stuffed into the stack view on the
TopTotalsCellcard. Now it only uses theTopTotalsCellcard to show the header viaDetailSubtitlesHeaderRow. The stack view is left empty. Instead, aUITableViewCellis added to the table for each data row via:DetailExpandableRow- for parent rowsDetailExpandableChildRow- for child rowsAnd, because Referrers
Search Enginesrows can be expanded twice, "grandchild" rows are now supported.This also addresses two other issues:
From #11080 - When no icon is available then show
gridicons-globe.From #11674 (comment) - fix
gridicons-searchicon size.Update release notes:
RELEASE-NOTES.txt.To test:
View more.Search Enginesrow: (tip: en.blog has this row)For an expandable row...).