Skip to content

[Stats Refresh] placeholder while loading icon - #11745

Merged
ScoutHarris merged 1 commit into
developfrom
feature/11744-loading_icon
May 22, 2019
Merged

[Stats Refresh] placeholder while loading icon#11745
ScoutHarris merged 1 commit into
developfrom
feature/11744-loading_icon

Conversation

@ScoutHarris

@ScoutHarris ScoutHarris commented May 22, 2019

Copy link
Copy Markdown
Contributor

Fixes #11744

To test:

  • On a slow network, go to either Period Referrers or Insights Publicize.
    • These are the only two that are downloaded and aren't user icons.
  • Until the icon is loaded, verify a grey box is shown.
  • Once the icon is loaded, verify the icon appears.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

loading icon

@ScoutHarris ScoutHarris added this to the 12.6 milestone May 22, 2019
@ScoutHarris
ScoutHarris requested a review from danielebogo May 22, 2019 00:56
@ScoutHarris ScoutHarris self-assigned this May 22, 2019
@ScoutHarris ScoutHarris mentioned this pull request May 22, 2019
Closed
45 tasks
@SylvesterWilmott

SylvesterWilmott commented May 22, 2019

Copy link
Copy Markdown

Looks good @ScoutHarris !

danielebogo
danielebogo approved these changes May 22, 2019
View reviewed changes

@danielebogo danielebogo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@ScoutHarris
ScoutHarris merged commit 1a92ead into develop May 22, 2019
@ScoutHarris
ScoutHarris deleted the feature/11744-loading_icon branch May 22, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SylvesterWilmott SylvesterWilmott Awaiting requested review from SylvesterWilmott
1 more reviewer
@danielebogo danielebogo danielebogo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ScoutHarris ScoutHarris

Labels

None yet

Projects

None yet

Milestone

12.6 ❄️

Development

Successfully merging this pull request may close these issues.

[Stats Refresh] placeholder while loading icon

3 participants

@ScoutHarris @SylvesterWilmott @danielebogo