[Stats Refresh] empty "simple" stat cards now show No data yet label - #11748
Merged
Conversation
45 tasks
danielebogo
approved these changes
May 22, 2019
danielebogo
left a comment
danielebogo
left a comment
Contributor
There was a problem hiding this comment.
Well done @ScoutHarris ! It worked as expected! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11746
When I first added support for details views, in
addRowsI added a check forlimitRowsDisplayedbefore adding aStatsNoDataRow(since details doesn't limit rows). Clearly I didn't realize I brokeSimpleTotalsCells, which don't limit rows either. However, since details rows are added differently now, I've simply removed that check.To test:
No data yetinstead of just being blank when there is no data.Update release notes:
RELEASE-NOTES.txt.