Skip to content

[Stats Refresh] Add missing separator lines - #11754

Merged
ScoutHarris merged 5 commits into
developfrom
fix/separator_lines
May 22, 2019
Merged

[Stats Refresh] Add missing separator lines#11754
ScoutHarris merged 5 commits into
developfrom
fix/separator_lines

Conversation

@ScoutHarris

Copy link
Copy Markdown
Contributor

Fixes #n/a

This adds some missing separator lines. Specifically:

  • Insights Comments and Followers cards - top line on card
  • Insights Publicize card - bottom line on card
  • Detail views for all non-expandable stats - bottom line on last row
  • Insights Countries card - bottom line on card
  • Period Published details - top line on first row

cc @SylvesterWilmott - so you know which ones I fixed.

To test:

  • Go to the Stats listed above. Verify the lines appear as expected.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@ScoutHarris ScoutHarris added this to the 12.6 milestone May 22, 2019
@ScoutHarris
ScoutHarris requested a review from a user May 22, 2019 21:07
@ScoutHarris ScoutHarris self-assigned this May 22, 2019
@ScoutHarris ScoutHarris mentioned this pull request May 22, 2019
45 tasks

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScoutHarris I checked out the branch and took it for a spin on my iPhone XS. Good news - I'm seeing the lines you called out in the testing instructions!

:shipit:

@ScoutHarris
ScoutHarris merged commit f1e1526 into develop May 22, 2019
@ScoutHarris
ScoutHarris deleted the fix/separator_lines branch May 22, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant