Skip to content

[Stats Refresh] Insights Posting Activity detail: correct layout on rotation - #11801

Merged
ScoutHarris merged 1 commit into
developfrom
fix/11796-posting_activity_detail_layout
May 29, 2019
Merged

[Stats Refresh] Insights Posting Activity detail: correct layout on rotation#11801
ScoutHarris merged 1 commit into
developfrom
fix/11796-posting_activity_detail_layout

Conversation

@ScoutHarris

Copy link
Copy Markdown
Contributor

Fixes #11796

To test:

NOTE: The problem didn't happen on every device, but I was able to repro it on the iPhone Xs simulator.

  • Go to Insights Posting Activity and select View more.
  • Rotate the device to landscape and back.
  • Verify the months layout properly.

posting_activity_detail

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@ScoutHarris ScoutHarris added this to the 12.6 milestone May 28, 2019
@ScoutHarris ScoutHarris self-assigned this May 28, 2019
@ScoutHarris ScoutHarris mentioned this pull request May 28, 2019
45 tasks

@danielebogo danielebogo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@SylvesterWilmott

Copy link
Copy Markdown

Thanks for the fix @ScoutHarris

@ScoutHarris
ScoutHarris merged commit 6e9ec1c into develop May 29, 2019
@ScoutHarris
ScoutHarris deleted the fix/11796-posting_activity_detail_layout branch May 29, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Stats Refresh] Insights Posting Activity detail: incorrect layout after rotation

3 participants