[Stats Refresh] Period Authors: fix expanded row height - #11825
Merged
Conversation
…int, to allow width and height to be different values.
…icon is configured.
… = 1 fixes the issue where the child row was too tall.
45 tasks
danielebogo
approved these changes
May 31, 2019
danielebogo
left a comment
danielebogo
left a comment
Contributor
There was a problem hiding this comment.
Hey @ScoutHarris LGTM!
One question: with Sherlock and the XCode inspector I see 43.3333333 as row height. Is it correct?
If so just 
Contributor
Author
|
Hey @danielebogo . The cells are a bit dynamic, they're not hard coded to 44. I should have said |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11800
In order for the child row to appear indented, the icon image view is actually shown, just with no image. The side effect of this was the child row height was affected by the image view height.
To avoid this, if there is no image, the image height is now set to 1. The width is still the parent image width.
To note, this only fixes the overview card. I've created #11824 to fix the detail view.
To test:
Update release notes:
RELEASE-NOTES.txt.