Skip to content

Update Tracks to 0.8.0 - #15770

Merged
jkmassel merged 3 commits into
developfrom
update/tracks
Feb 4, 2021
Merged

Update Tracks to 0.8.0#15770
jkmassel merged 3 commits into
developfrom
update/tracks

Conversation

@jkmassel

@jkmassel jkmassel commented Feb 2, 2021

Copy link
Copy Markdown
Contributor

Upgrades Sentry and cleans up associated code.

To test:

  • Download the installable build from this PR onto a test device
  • Go to Me > App Settings > Debug, and tap "Send Log Message", then "Send Test Crash". Relaunch the app.
  • Go to https://sentry.io/organizations/a8c/discover/results/ and enter user.email:$your_email, and note that the events show up (might take up to 5 minutes)

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jkmassel jkmassel added the Tooling Build, Release, and Validation Tools label Feb 2, 2021
@jkmassel jkmassel added this to the 16.7 milestone Feb 2, 2021
@jkmassel jkmassel self-assigned this Feb 2, 2021
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Feb 2, 2021

Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 41547. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Feb 3, 2021

Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@jkmassel
jkmassel marked this pull request as ready for review February 3, 2021 21:23
class UserSettings {

@objc
@UserDefault("crashlytics_opt_out", defaultValue: false)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@leandroalonso leandroalonso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described! I also testing opting-out the reports and they weren't sent as expected. :shipit:

Thank you so much @jkmassel!!

@jkmassel
jkmassel merged commit 02665f2 into develop Feb 4, 2021
@jkmassel
jkmassel deleted the update/tracks branch February 4, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tooling Build, Release, and Validation Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants