Remove switch to classic from gutenberg - #16131
Merged
Merged
Conversation
Addresses: wordpress-mobile/gutenberg-mobile#3048 (for iOS) In discussion with @kyleaparker, we decided that it's best to fast-track the removal of the "switch to classic" option in the block editor. This PR will be scheduled for release in v17.1 alongside a matching change for Android.
Generated by 🚫 dangerJS |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Contributor
Author
|
Tested build 44237:
Looks good 🟢 Submitting for review! |
illusaen
approved these changes
Mar 22, 2021
illusaen
left a comment
Contributor
There was a problem hiding this comment.
Looks good! I <3 this change :)
Contributor
Author
|
Thanks @illusaen! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: wordpress-mobile/gutenberg-mobile#3048 (for iOS)
In discussion with @kyleaparker, we decided that it's best to fast-track the removal of the "switch to classic" option in the block editor. This PR will be scheduled for release in v17.1 alongside a matching change for Android.
I think this change doesn't warrant inclusion in
RELEASE-NOTES.txt, but if anyone thinks differently I'd love to hear.To test
Regression notes (new ✨ )
I'm adding this section to try out @startuptester's proposal to improve code quality.
Potential unintended areas of impact (regressions)
The app has a couple of different editors (block editor, classic editor, story editor, HTML editor) and this change is only intended to prevent navigation from the block editor to the classic editor.
What you did to manually test those/ what existing automated tests you relied on
I gave these the four editors (block, classic, story, HTML) a quick test, keeping an eye out for any unintended side-effects of this change.
What automated tests you added or what prevented you from doing so
There are no existing UI tests nor unit tests that cover switching from the block editor to the classic editor, so there were no tests to update. Since we're removing functionality here, there's are no tests to add, either.
PR submission checklist
RELEASE-NOTES.txtif necessary.