Skip to content

Blogging Prompts List: initial view - #18505

Merged
ScoutHarris merged 4 commits into
trunkfrom
feature/18502-prompts_initial_view
May 4, 2022
Merged

Blogging Prompts List: initial view#18505
ScoutHarris merged 4 commits into
trunkfrom
feature/18502-prompts_initial_view

Conversation

@ScoutHarris

@ScoutHarris ScoutHarris commented May 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Ref: #18502

This adds an initial Blogging Prompts list view.

To test:

  • Enable bloggingPrompts feature flag.
  • Select the My Site Home tab.
  • On the prompt card menu, select View more prompts.
  • Verify the Prompts view is displayed.
    • 10 stub empty rows.
    • Filter tab bar at the top under the nav bar.
show_me.mp4

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added this to the 19.9 milestone May 3, 2022
@ScoutHarris ScoutHarris self-assigned this May 3, 2022
@ScoutHarris
ScoutHarris requested a review from wargcm May 3, 2022 23:39
@ScoutHarris
ScoutHarris marked this pull request as ready for review May 3, 2022 23:39
@ScoutHarris ScoutHarris mentioned this pull request May 3, 2022
Closed
7 tasks
@wpmobilebot

wpmobilebot commented May 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18505-0d08668 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot

wpmobilebot commented May 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18505-0d08668 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

wargcm
wargcm approved these changes May 4, 2022
View reviewed changes

@wargcm wargcm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread WordPress/Classes/ViewRelated/Blog/Blogging Prompts/BloggingPromptsViewController.swift Outdated
// TODO:
// - track selected filter changed
// - refresh view for selected filter
}

@wargcm wargcm May 4, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nitpick]: Indentation is off for this closing brace.

@ScoutHarris ScoutHarris May 4, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops. Thanks!

Comment thread WordPress/WordPress.xcodeproj/project.pbxproj
Comment on lines -12740 to +12768
C77FC90628009C3C00726F00 /* Onboarding Questions Prompt */,
3F170D2A2654615900F6F670 /* Blogging Reminders */,
FA73D7E72798766300DF24B3 /* Site Picker */,
1716AEFA25F2926C00CF49EC /* My Site */,
F1863714253E49B8003D4BEF /* Add Site */,
3F43603423F368BF001DEE70 /* Blog Details */,
3F37609B23FD803300F0D87F /* Blog + Me */,
FA73D7D7278D9E6300DF24B3 /* Blog Dashboard */,
3F43603423F368BF001DEE70 /* Blog Details */,
3F43603523F368CA001DEE70 /* Blog List */,
3F43603623F36962001DEE70 /* Blog Selector */,
3F37609B23FD803300F0D87F /* Blog + Me */,
98A047702821BFB6001B4E2D /* Blogging Prompts */,
3F170D2A2654615900F6F670 /* Blogging Reminders */,
1716AEFA25F2926C00CF49EC /* My Site */,
C77FC90628009C3C00726F00 /* Onboarding Questions Prompt */,
4395A15E210672C900844E8E /* QuickStart */,
E6431DDE1C4E890B00FD8D90 /* Sharing */,
FA5C74091C596E69000B528C /* Site Management */,
FA73D7E72798766300DF24B3 /* Site Picker */,

@wargcm wargcm May 4, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💯

@ScoutHarris

ScoutHarris commented May 4, 2022

Copy link
Copy Markdown
Contributor Author

Thanks @wargcm !

@ScoutHarris
ScoutHarris enabled auto-merge May 4, 2022 18:11
@ScoutHarris
ScoutHarris merged commit 59f951a into trunk May 4, 2022
@ScoutHarris
ScoutHarris deleted the feature/18502-prompts_initial_view branch May 4, 2022 18:30
@ScoutHarris ScoutHarris mentioned this pull request May 9, 2022
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@wargcm wargcm wargcm approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ScoutHarris ScoutHarris

Labels

Blogging Prompts

Projects

None yet

Milestone

19.9

Development

Successfully merging this pull request may close these issues.

3 participants

@ScoutHarris @wpmobilebot @wargcm