Blogging Prompts List: add the ability to show empty views for different scenarios. - #18515
Conversation
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
wargcm
left a comment
There was a problem hiding this comment.
Code looks good! I found a couple minor UI issues which probably don't need to be addressed in this PR:
-
There's some display issues for the no connection text in landscape mode when using large accessibility text. This is probably an existing issue with the no results view.

-
There's a small flicker when changing tabs. I compared it to the followers page for reference.
flicker.mp4
Indeed it is. I'll not address that here.
This will be fixed when the logic is added to properly display the views. Right now it's just always readding the empty view so it appears for all the tabs, which causes the flickering. In the future, it will depend on the loading status, tab contents, and whether it's already being displayed. i.e. I'll fix it later! 😄 |
Ref: #18502
This adds the ability to show empty views for different scenarios.
Since the view is not fetching prompts yet, some hacking in
BloggingPromptsViewControlleris required to get each empty view to show, which is noted below. The logic to toggle these states appropriately will be added later.For the uninitiated 😄 , the
NoResultsViewControllerprovides this magic:To test:
bloggingPromptsfeature flag.Hometab > prompt card >View more prompts.View hacking:
promptCount= 0.promptCount= 0.isLoading= true.viewDidLoad, replaceshowNoResultsViewIfNeededwithshowErrorView.Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.