Blogging Prompts: Add blogging prompts attribution to prompts dashboard card - #18574
Merged
Merged
Conversation
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
Contributor
You can test the changes in WordPress from this Pull Request by:
|
ScoutHarris
approved these changes
May 12, 2022
ScoutHarris
left a comment
Contributor
There was a problem hiding this comment.
Heya @wargcm . I had one quibble, otherwise looks good!
![]()
| } | ||
|
|
||
| private struct Strings { | ||
| static let fromTextFormat = NSLocalizedString("From %@", comment: "From string format for blogging prompts attribution") |
Contributor
There was a problem hiding this comment.
Some comments about this string:
- In string formats, we always use positional placeholders. i.e. this should be
%1$@instead of%@. (Ref pbMoDN-1Df-p2). - We explain what each placeholder is for in the
comment. - The
commentis a bit confusing due to the usage ofFromand its context.
Maybe it can be something like:
NSLocalizedString("From %1$@", comment: "Format for blogging prompts attribution. %1$@ is the attribution source.")
Contributor
Author
There was a problem hiding this comment.
Thanks for the catch and the info! I updated the PR with your recommendation: 760e576
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #18558
Description
Adds Day One attribution to the dashboard prompts card.
Testing
To test:
bloggingPromptsfeature flagScreenshots
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.