Skip to content

Blogging Prompts: Add blogging prompts attribution to prompts dashboard card - #18574

Merged
wargcm merged 2 commits into
trunkfrom
feature/18558-prompt-attribution-dashboard-card
May 12, 2022
Merged

Blogging Prompts: Add blogging prompts attribution to prompts dashboard card#18574
wargcm merged 2 commits into
trunkfrom
feature/18558-prompt-attribution-dashboard-card

Conversation

@wargcm

@wargcm wargcm commented May 11, 2022

Copy link
Copy Markdown
Contributor

See: #18558

Description

Adds Day One attribution to the dashboard prompts card.

Testing

To test:

  • Enable bloggingPrompts feature flag
  • Modify the prompt being fetched to be the example prompt
  • Launch the app and navigate to the 'My Site' tab
  • Verify:
    • Day One icon
    • Text
      • Accessibility
      • Dark mode
  • Modify prompt back to non-attributed prompt
  • Launch the app and navigate to the 'My Site' tab
  • Verify attribution doesn't appear

Screenshots

Light Dark
Screen Shot 2022-05-11 at 5 55 58 PM Screen Shot 2022-05-11 at 6 02 39 PM

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18574-1fa1b67 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot

wpmobilebot commented May 11, 2022

Copy link
Copy Markdown
Contributor
You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18574-760e576 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@ScoutHarris ScoutHarris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya @wargcm . I had one quibble, otherwise looks good!

:shipit:

}

private struct Strings {
static let fromTextFormat = NSLocalizedString("From %@", comment: "From string format for blogging prompts attribution")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about this string:

  • In string formats, we always use positional placeholders. i.e. this should be %1$@ instead of %@. (Ref pbMoDN-1Df-p2).
  • We explain what each placeholder is for in the comment.
  • The comment is a bit confusing due to the usage of From and its context.

Maybe it can be something like:
NSLocalizedString("From %1$@", comment: "Format for blogging prompts attribution. %1$@ is the attribution source.")

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch and the info! I updated the PR with your recommendation: 760e576

@wargcm
wargcm merged commit 436f005 into trunk May 12, 2022
@wargcm
wargcm deleted the feature/18558-prompt-attribution-dashboard-card branch May 12, 2022 19:38
dvdchr added a commit that referenced this pull request May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants