Skip to content

Blogging Prompts Feature Introduction: use real prompt for new post - #18597

Merged
ScoutHarris merged 2 commits into
trunkfrom
feature/18429-fi_try_it_prompt
May 12, 2022
Merged

Blogging Prompts Feature Introduction: use real prompt for new post#18597
ScoutHarris merged 2 commits into
trunkfrom
feature/18429-fi_try_it_prompt

Conversation

@ScoutHarris

@ScoutHarris ScoutHarris commented May 12, 2022

Copy link
Copy Markdown
Contributor

Ref: #18429

When Try it now is selected on the Blogging Prompts feature introduction, a prompt is fetched and passed to the post editor.

To test:

  • Enable bloggingPrompts feature flag.
  • Select Try it now on the feature introduction.
  • Verify the post content matches the prompt. (It should match the dashboard prompt card and FAB header prompt.)
  • In BloggingPromptsIntroductionPresenter:fetchPrompt, call completion(nil) in the success block to fake a failure.
bloggingPromptsService.fetchTodaysPrompt(success: { (prompt) in
    completion(nil)
    // completion(prompt)
}, failure: { (error) in
...
  • Select Try it now on the feature introduction.
  • Verify:
    • The feature introduction is dismissed.
    • An error notice is displayed.
Post Editor Error Notice
post error

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added this to the 19.9 milestone May 12, 2022
@ScoutHarris ScoutHarris self-assigned this May 12, 2022
@ScoutHarris
ScoutHarris requested a review from wargcm May 12, 2022 19:47
@ScoutHarris
ScoutHarris marked this pull request as ready for review May 12, 2022 19:47
@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18597-82f8c5c on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wargcm wargcm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :shipit:

@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18597-82f8c5c on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@ScoutHarris

Copy link
Copy Markdown
Contributor Author

Thanks @wargcm !

@ScoutHarris
ScoutHarris merged commit 8c4b3ca into trunk May 12, 2022
@ScoutHarris
ScoutHarris deleted the feature/18429-fi_try_it_prompt branch May 12, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants