Skip to content

Blogging Prompts: Add attribution to prompts header view in action sheet - #18598

Merged
wargcm merged 1 commit into
trunkfrom
feature/18558-prompt-attribution-action-sheet
May 13, 2022
Merged

Blogging Prompts: Add attribution to prompts header view in action sheet#18598
wargcm merged 1 commit into
trunkfrom
feature/18558-prompt-attribution-action-sheet

Conversation

@wargcm

@wargcm wargcm commented May 12, 2022

Copy link
Copy Markdown
Contributor

See: #18558

Description

Adds the prompts attribution to the header view in the action sheet.

Testing

To test:

  • Enable bloggingPrompts feature flag
  • Modify the header view to use the example prompt if the current days prompt is not attributed to Day One
  • Launch and navigate to 'My Site' tab
  • Tap on create new '+'
  • Verify:
    • Day One icon is correct
    • Attribution is correct

Screenshots

Light Dark
Screen Shot 2022-05-12 at 4 01 56 PM Screen Shot 2022-05-12 at 4 02 05 PM

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wargcm
wargcm requested a review from ScoutHarris May 12, 2022 20:06
@wargcm wargcm self-assigned this May 12, 2022
@wargcm wargcm added this to the 19.9 milestone May 12, 2022
@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18598-e180c8a on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18598-e180c8a on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@ScoutHarris

Copy link
Copy Markdown
Contributor

I saw some issues with dynamic text.

  • Compact card - the attribution isn't dynamic at all.
iPad iPhone
ipad_fab iphone_fab
  • Dashboard card - this is a bit odd (which is how I missed it on the previous PR):
    • If you're on the dashboard and change the text size, the attribution resizes.
    • If you are not on the dashboard and change the text size, when you view the dashboard the attribution does not resize.
    • This was pretty easy to reproduce on iPad. I only saw it a couple times on iPhone.

ipad_dashboard

I'll go ahead and approve this PR since these can be addressed separately.

@wargcm

wargcm commented May 13, 2022

Copy link
Copy Markdown
Contributor Author

Thanks @ScoutHarris! I'll get another PR shortly to address the header menu text. And that dashboard behavior is a bit strange, I'll probably have to look into it.

@wargcm
wargcm merged commit 4386a78 into trunk May 13, 2022
@wargcm
wargcm deleted the feature/18558-prompt-attribution-action-sheet branch May 13, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants