Skip to content

Blogging Prompt Cards: pass real prompt to post editor - #18599

Merged
ScoutHarris merged 2 commits into
trunkfrom
feature/18429-post_prompt_from_cards
May 13, 2022
Merged

Blogging Prompt Cards: pass real prompt to post editor#18599
ScoutHarris merged 2 commits into
trunkfrom
feature/18429-post_prompt_from_cards

Conversation

@ScoutHarris

@ScoutHarris ScoutHarris commented May 12, 2022

Copy link
Copy Markdown
Contributor

Ref: #18429

When answering a prompt from the dashboard card or the compact card, the post is now populated with the actual post.

To test:

  • Enable bloggingPrompts feature flag.
  • Select Answer prompt from the FAB header.
    • Verify the post is populated with the prompt.
  • Select Answer prompt from the dashboard prompt card.
    • Verify the post is populated with the prompt.
fab dashboard post

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added this to the 19.9 milestone May 12, 2022
@ScoutHarris ScoutHarris self-assigned this May 12, 2022
@ScoutHarris
ScoutHarris requested a review from wargcm May 12, 2022 22:06
@ScoutHarris
ScoutHarris marked this pull request as ready for review May 12, 2022 22:06
@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18599-faaa4ab on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18599-faaa4ab on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wargcm wargcm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ScoutHarris
ScoutHarris enabled auto-merge May 13, 2022 16:00
@ScoutHarris
ScoutHarris merged commit c8fdf66 into trunk May 13, 2022
@ScoutHarris
ScoutHarris deleted the feature/18429-post_prompt_from_cards branch May 13, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants