Blogging Prompts: use cached prompts for compact card and prompts list - #18658
Merged
Conversation
Contributor
You can test the changes in WordPress from this Pull Request by:
|
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
4 tasks
Contributor
Author
|
Thanks @wargcm ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #18429
This updates the FAB header prompt and the Prompts List to use cached prompts if available.
To easily confirm which prompts are used, messages are logged when cached prompts are used and when prompts are fetched from remote. These will be removed before merging.
To test:
bloggingPromptsfeature flag.🔴 todaysPrompt > fetching..🔴 todaysPrompt > returning local.. (If you're on the Dashboard, you may see this twice - for the FAB and for the dashboard card.)🔴 listPrompts > fetching.is logged.🔴 listPrompts > returning local.is logged.Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.