Skip to content

Blogging Prompts: use cached prompts for compact card and prompts list - #18658

Merged
ScoutHarris merged 5 commits into
trunkfrom
feature/18429-use_cached_prompts
May 19, 2022
Merged

Blogging Prompts: use cached prompts for compact card and prompts list#18658
ScoutHarris merged 5 commits into
trunkfrom
feature/18429-use_cached_prompts

Conversation

@ScoutHarris

@ScoutHarris ScoutHarris commented May 18, 2022

Copy link
Copy Markdown
Contributor

Ref: #18429

This updates the FAB header prompt and the Prompts List to use cached prompts if available.

To easily confirm which prompts are used, messages are logged when cached prompts are used and when prompts are fetched from remote. These will be removed before merging.

To test:

  • Start with a fresh install to purge any cached prompts.
  • Enable bloggingPrompts feature flag.
  • When the app first launches, the FAB gets a prompt. Verify this is logged: 🔴 todaysPrompt > fetching..
  • Navigate away from and back to My Site. The FAB once again needs a prompt. Verify this is logged: 🔴 todaysPrompt > returning local.. (If you're on the Dashboard, you may see this twice - for the FAB and for the dashboard card.)
  • Go to the Prompts List. Verify:
    • 🔴 listPrompts > fetching. is logged.
    • The loading view is displayed. (The table can be seen behind the loading view. I'll address that separately.)
    • 11 prompts are displayed once loaded.
  • Navigate away from and back to the Prompts List. Verify:
    • 🔴 listPrompts > returning local. is logged.
    • The loading view may not display since this is a quick action.
    • 11 prompts are displayed.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot

wpmobilebot commented May 18, 2022

Copy link
Copy Markdown
Contributor
You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18658-23679f2 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot

wpmobilebot commented May 19, 2022

Copy link
Copy Markdown
Contributor
You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18658-23679f2 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wargcm wargcm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ScoutHarris

Copy link
Copy Markdown
Contributor Author

Thanks @wargcm !

@ScoutHarris
ScoutHarris enabled auto-merge May 19, 2022 21:05
@ScoutHarris
ScoutHarris merged commit 69fe3a2 into trunk May 19, 2022
@ScoutHarris
ScoutHarris deleted the feature/18429-use_cached_prompts branch May 19, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants