Skip to content

Blogging Prompt Cards: hide Share button - #18670

Merged
ScoutHarris merged 1 commit into
trunkfrom
feature/18429-hide_share_button
May 19, 2022
Merged

Blogging Prompt Cards: hide Share button#18670
ScoutHarris merged 1 commit into
trunkfrom
feature/18429-hide_share_button

Conversation

@ScoutHarris

@ScoutHarris ScoutHarris commented May 19, 2022

Copy link
Copy Markdown
Contributor

Ref: #18429

This hides this Share button on the dashboard prompt card and FAB prompt header.

To test:

  • Implement the hacks below to show Answered states on the cards.
  • Enable bloggingPrompts feature flag.
  • Verify the Share button is not displayed on the dashboard prompt card or the FAB prompt header.

Hacks to show Answered states:

  • DashboardPromptsCardCell - return true for isAnswered.
  • BloggingPromptsHeaderView - set answered = true in configure.

no_share

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added this to the 20.0 milestone May 19, 2022
@ScoutHarris ScoutHarris self-assigned this May 19, 2022
@ScoutHarris
ScoutHarris requested a review from wargcm May 19, 2022 16:39
@ScoutHarris
ScoutHarris marked this pull request as ready for review May 19, 2022 16:39
@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18670-bb33bec on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18670-bb33bec on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wargcm wargcm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

@ScoutHarris
ScoutHarris merged commit 69195db into trunk May 19, 2022
@ScoutHarris
ScoutHarris deleted the feature/18429-hide_share_button branch May 19, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants