Blogging Prompts: Add check to prompts header to only display for WP sites - #18819
Merged
Conversation
36 tasks
Contributor
You can test the changes in WordPress from this Pull Request by:
|
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
Contributor
|
Hey Chris 👋 |
alpavanoglu
approved these changes
Jun 8, 2022
Contributor
Author
|
Posting here as well just in case anyone comes across this PR. We discussed this in Slack. I'm actually not sure if our internal site is hosted by a 3rd party or if it's the case the internal sites are not accessible by our API's. I'm assuming one of the two is the case. Thanks for the review @alpavanoglu! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #18429
Description
Hides the prompts action sheet header view on self-hosted sites.
Testing
To test:
bloggingPromptsfeature flag inFeatureFlag.swiftRegression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.