Blogging Prompts: Hide self-hosted sites in the site picker from the prompts intro view - #18829
Merged
Merged
Conversation
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
Contributor
You can test the changes in WordPress from this Pull Request by:
|
36 tasks
alpavanoglu
reviewed
Jun 10, 2022
alpavanoglu
left a comment
Contributor
There was a problem hiding this comment.
Oops I forgot to publish my review :-] It isn't major but I also think it could be misleading later if we skip it now
| @@ -284,9 +294,12 @@ private extension BlogListDataSource { | |||
| } | |||
|
|
|||
| var allBlogs: [Blog] { | |||
Contributor
There was a problem hiding this comment.
The name of this variable should be updated I think to something like filteredBlogs as now it won't be allBlogs all times.
Contributor
Author
There was a problem hiding this comment.
True, it's a bit misleading at the moment. I updated this variable with your suggestion and the allBlogsCount to blogsCount in e932d8e. Thanks!
ScoutHarris
self-requested a review
June 10, 2022 22:47
ScoutHarris
approved these changes
Jun 10, 2022
ScoutHarris
left a comment
Contributor
There was a problem hiding this comment.
Created a self-hosted site via jurassic.ninja and verified it didn't show in the list.
![]()
Contributor
Author
|
Thank you @ScoutHarris! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #18429
Description
Filters out self-hosted sites from the site picker when tapping on 'Try it now' from the prompts feature introduction view.
Testing
Note: I don't have any self-hosted sites, so I manually changed the return value from
isAccessibleThroughWPCom. It might be easier doing it this way unless you have a self-hosted site.To test:
bloggingPromptsfeature flag inFeatureFlag.swiftRegression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.