Jetpack Focus: Fix notifications screenshot for iPad - #19126
Merged
Conversation
added 4 commits
July 29, 2022 09:48
The comments details page wasn’t loading correctly because the site id didn’t match for the /me/sites endpoint and the /sites/<siteId>/comments/<commentId> endpoint.
7 tasks
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
Contributor
You can test the changes in WordPress from this Pull Request by:
|
hassaanelgarem
approved these changes
Aug 1, 2022
hassaanelgarem
left a comment
Contributor
There was a problem hiding this comment.
Works as described 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #18960
Description
This PR fixes and issue where the notification details screen wasn't loading properly on iPad for the screenshot targets (i.e.
WordPressScreenshotGenerationandJetpackScreenshotGeneration).How to test
Test for both the
WordPressScreenshotGenerationandJetpackScreenshotGenerationtargetsrake mockstestGenerateScreenshots()on an iPad simulatorNotes
FYI @shaunandrews @hassaanelgarem I removed the call to tap the reply button on the notification details screen. Previously, we were tapping the reply button which brought up the hardware keyboard onto the screen. For reference, this is what it used to look like. But the new notification details design fills up the screen, and bringing up the hardware keyboard would obscure a lot of the UI elements. Lmk what you think :)
Regression Notes
WordPressScreenshotGenerationtargetWordPressScreenshotGenerationPR submission checklist:
RELEASE-NOTES.txtif necessary.