Skip to content

Test PR for strings linting in CI#19544

Closed
mokagio wants to merge 4 commits into
trunkfrom
mokagio/test-genestrings-in-ci
Closed

Test PR for strings linting in CI#19544
mokagio wants to merge 4 commits into
trunkfrom
mokagio/test-genestrings-in-ci

Conversation

@mokagio

@mokagio mokagio commented Nov 1, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread fastlane/lanes/localization.rb Outdated
)

git_commit(path: [wordpress_en_lproj], message: 'Update strings for localization', allow_nothing_to_commit: true)
unless options[:skip_commit]

@wpmobilebot wpmobilebot Nov 1, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.

@mokagio
mokagio force-pushed the mokagio/test-genestrings-in-ci branch from ed7f71f to 8d0d572 Compare November 1, 2022 10:13
@wpmobilebot

wpmobilebot commented Nov 1, 2022

Copy link
Copy Markdown
Contributor
You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19544-f0fa648 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot

wpmobilebot commented Nov 1, 2022

Copy link
Copy Markdown
Contributor
You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19544-f0fa648 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@mokagio
mokagio force-pushed the mokagio/test-genestrings-in-ci branch 3 times, most recently from 4ea56b2 to 3009f79 Compare November 2, 2022 03:35
@mokagio
mokagio force-pushed the mokagio/test-genestrings-in-ci branch 5 times, most recently from 193ad92 to 6d01c35 Compare November 9, 2022 04:20
@mokagio
mokagio force-pushed the mokagio/test-genestrings-in-ci branch 2 times, most recently from b31a9cb to 55723f4 Compare November 19, 2022 05:33
@mokagio
mokagio force-pushed the mokagio/test-genestrings-in-ci branch from 55723f4 to 6c2e50b Compare November 25, 2022 06:02
@mokagio
mokagio force-pushed the mokagio/test-genestrings-in-ci branch from 6c2e50b to f0fa648 Compare November 25, 2022 06:08
@mokagio mokagio closed this Dec 2, 2022
@mokagio
mokagio deleted the mokagio/test-genestrings-in-ci branch December 2, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants