Remove unnecessary SchedulingViewControllerProtocol - #19708
Merged
Conversation
This protocol used to be a facade between `SchedulingDatePickerViewController` and `SchedulingCalendarViewController` but the latter has been removed in a60d3d9 so we can remove the abstraction.
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
Contributor
You can test the changes in WordPress from this Pull Request by:
|
joshheald
approved these changes
Dec 2, 2022
joshheald
left a comment
Contributor
There was a problem hiding this comment.
Code looks good. I've not tested it though as I don't have a WPiOS dev env set up right now: I added this on a maintenance rotation. Since it's building, I expect it's fine.
| @@ -26,7 +26,7 @@ class DateCoordinator { | |||
| // MARK: - Date Picker | |||
|
|
|||
| @available(iOS, introduced: 14.0) | |||
Contributor
There was a problem hiding this comment.
Perhaps this can be removed as well? I can think of arguments for or against, so either way is good with me, but just checking whether you've considered it.
Contributor
Author
There was a problem hiding this comment.
Good catch. I should have mentioned that I left that for #19709 . Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This protocol used to be a facade between
SchedulingDatePickerViewControllerandSchedulingCalendarViewControllerbut the latter has been removed in a60d3d9 during the iOS 13 Widgets removal so we can remove the abstraction.Testing
If CI builds, we're good to go.
Regression Notes
RELEASE-NOTES.txtif necessary. N.A.