Fix site icon alert logic

[momo-ozawa]

Addresses #19709 (comment)

How to test

1. On My Site tap on your site icon
2. ✅ Validate: the action sheet displays a "create with emoji" option
3. Disable the Site Icon Creator flag via the debug menu - Profile Icon > App Settings > Debug
4. On My Site tap on your site icon
5. ✅ Validate: the action sheet DOES NOT display a "create with emoji" option

Site Icon Creator Enabled	Site Icon Creator Disabled

Regression Notes

1. Potential unintended areas of impact
   n/a

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   n/a

3. What automated tests I added (or what prevented me from doing so)
   n/a

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[momo-ozawa]

On a separate note, I see that this feature flag is set to BuildConfiguration.current != .appStore. I love this feature, I'd love to turn it on at some point! (cc: @frosty)

[wpmobilebot]

You can test the changes in WordPress from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19740-0336657 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[wpmobilebot]

You can test the changes in Jetpack from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19740-0336657 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[hassaanelgarem]

Works as described 👍

Fun fact, even though we were indeed effectively trying to show two action sheets, only the first one was ever going to be shown. This appears to be handled internally by UIViewController.present()

The following can be found in the logs:

Attempt to present <UIAlertController: 0x133013c00> on <WPTabBarController: 0x129844800> (from <WordPress.SitePickerViewController: 0x151a16de0>) which is already presenting <UIAlertController: 0x13180ea00>.

[momo-ozawa]

This appears to be handled internally by UIViewController.present()

TIL! Thanks for sharing! Now that I'm thinking about it that's probably why this went unnoticed even though the flag is set to true for internal builds. Thanks again for investigating 🙇‍♀️

[frosty]

Thanks for the ping, @momo-ozawa! So the reason this isn't released is because someone raised a query that Apple may not be happy with this usage of their emoji images. I did start a side project to switch the emoji out for Twitter's open source emoji library, but I never finished it!