Fix Core Data concurrency issues in AccountService - #20394
Merged
Conversation
Contributor
|
| App Name | ||
| Configuration | Release-Alpha | |
| Build Number | pr20394-b1a6ae8 | |
| Version | 22.0 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | b1a6ae8 | |
| App Center Build | jetpack-installable-builds #4338 |
Contributor
|
| App Name | ||
| Configuration | Release-Alpha | |
| Build Number | pr20394-b1a6ae8 | |
| Version | 22.0 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | b1a6ae8 | |
| App Center Build | WPiOS - One-Offs #5312 |
crazytonyli
force-pushed
the
account-service-core-data-concurrency-issues
branch
from
March 24, 2023 01:54
da24705 to
e80dd11
Compare
crazytonyli
force-pushed
the
account-service-core-data-concurrency-issues
branch
from
March 24, 2023 01:54
e80dd11 to
aaa4ce6
Compare
mokagio
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed some Core Data concurrency issues on accessing
WPAccountfrom a wrong thread.I don't see a huge risk associated with these changes. The
updateDefaultBlogIfNeededfunction change is only a signature change, the code is still executed the way it used to be. The real logic ofsetupAppExtensionsWithDefaultAccountis now forced to run in the main thread, which is where it used to run too.Test instructions
A couple of features to verify:
Regression Notes
Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
What's described in the "Test instructions"
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txtif necessary.