Skip to content

Enable Core Data concurrency debug option in UI tests #20395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crazytonyli merged 1 commit into from
Apr 3, 2023
Merged

Enable Core Data concurrency debug option in UI tests #20395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WordPress/UITests/Tests/EditorGutenbergTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class EditorGutenbergTests: XCTestCase {
private var editorScreen: BlockEditorScreen!

override func setUpWithError() throws {
setUpTestSuite()
setUpTestSuite(crashOnCoreDataConcurrencyIssues: false)

_ = try LoginFlow.login(siteUrl: WPUITestCredentials.testWPcomSiteAddress, email: WPUITestCredentials.testWPcomUserEmail, password: WPUITestCredentials.testWPcomPassword)
editorScreen = try EditorFlow
Expand Down
10 changes: 9 additions & 1 deletion WordPress/UITests/Utils/XCTest+Extensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,22 @@ import XCTest

extension XCTestCase {

public func setUpTestSuite(for app: XCUIApplication = XCUIApplication(), removeBeforeLaunching: Bool = false) {
public func setUpTestSuite(
for app: XCUIApplication = XCUIApplication(),
removeBeforeLaunching: Bool = false,
crashOnCoreDataConcurrencyIssues: Bool = true
) {
super.setUp()

// In UI tests it is usually best to stop immediately when a failure occurs.
continueAfterFailure = false

app.launchArguments = ["-wpcom-api-base-url", WireMock.URL().absoluteString, "-no-animations", "-ui-testing"]

if crashOnCoreDataConcurrencyIssues {
app.launchArguments.append(contentsOf: ["-com.apple.CoreData.ConcurrencyDebug", "1"])
}

@mokagio mokagio Mar 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a subset of the tests use setUpTestSuite, which would result in this argument being applied inconsistently.

Have you considered using the test plan to set it and use this method to opt-out only?

image

@crazytonyli crazytonyli Mar 24, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. I hadn't thought about it, but I'll give it a go.

@crazytonyli crazytonyli Mar 24, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a subset of the tests use setUpTestSuite

The idea is only turn the debug option on for UI tests, which all calls this funciton, I think?

@mokagio mokagio Mar 28, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[UI tests] all calls this funciton, I think?

Oh, that is correct. I don't know why I got the impression only some of them called setUpTestSuite 🤔 But I checked each test and they all do.

Apologies.


if removeBeforeLaunching {
removeApp(app)
}
Expand Down